Repository navigation
Conversation
gte1
marked this pull request as ready for review
October 12, 2026 13:31
Fix PDO buffer sizing and wx grid refresh handling Normalize string buffer sizes before numeric comparisons and disable active grid editors before refreshing tables. Add regression coverage for both fixes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes related to PDO mapping logic, buffer size handling, and UI stability in the
objdictgenpackage. It also adds comprehensive tests to ensure correct behavior for various mapping scenarios.PDO mapping and buffer size logic improvements
FindMapVariableListinmaps.pyto usenode.IsEntry(index)for more accurate filtering of map entries, improving correctness in variable selection.node.pyto handle buffer sizes provided as strings, converting them to integers before use. This prevents type errors and ensures correct calculations.GetSubentryInfosfor type lookup, ensuring consistent handling for both arrays and records.UI stability enhancements
commondialogs.pyandsubindextable.pyto disable cell edit controls before resetting the grid, preventing UI inconsistencies or errors during updates. [1] [2]Testing enhancements
test_node.pyto cover various PDO mapping scenarios, including handling of buffer sizes as text, different mapping sources, and struct types, increasing test coverage and reliability.Fixed #84
This PR is mainly addressing the wx-based editor: the grid refresh/editor handling is wx-specific. The PDO buffer-size fix is in the shared Node model, though, so it also protects non-wx callers that load string buffer sizes.