Repository navigation
Conversation
Runs cargo audit against the root and lnvps_fw lockfiles on every PR and master push, plus weekly, so an advisory published against an already- pinned version surfaces without a code change. Read-only permissions and a SHA-pinned checkout; no secrets. Merge after LNVPS#429 (the RustSec dependency bumps): until those land, the gate is expected to be red on master. Found by the 2026-11-01 security audit.
v0l
requested changes
Nov 2, 2026
v0l
left a comment
Contributor
There was a problem hiding this comment.
Happy to have this, but it can't land blocking yet: even with #429 merged, cargo audit on master still fails. On #429's lockfile I get, in the root workspace: crypto-bigint 0.5.5 (RUSTSEC-2026-0387, a second copy via an older dep), quick-xml 0.39.4 (-0194, -0195), quinn-proto 0.11.16 (-0338..-0342), rustls 0.23.40 (-0285, -0346, -0348, -0349), rustls-webpki 0.103.13, webpki-roots/webpki-root-certs 1.0.8, and rsa RUSTSEC-2023-0071 (no fix exists). lnvps_fw/Cargo.lock still has webpki-roots 1.0.8.
To land:
- Add an
audit.toml(or--ignorelist) for advisories with no fix, starting with RUSTSEC-2023-0071, each with the reason. - Bump the rest in #429 (or a follow-up) until
cargo auditis green on both lockfiles, and show the green run. - Install a pinned prebuilt
cargo-audit(e.g.taiki-e/install-actionpinned by SHA) instead ofcargo installon every run. - Drop the comments from the workflow file; the "expects #429" note goes stale on merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the same independent audit (2026-11-01).
What
A new
security-audit.ymlworkflow runningcargo auditagainst both workspaces' lockfiles (Cargo.lockandlnvps_fw/Cargo.lock), matrix-isolated so one red lockfile doesn't hide the other:permissions: contents: read, no secrets, nothing pushed or commented;Sequencing
Merge after #429 (the RustSec dependency bumps): until those land, master's lockfiles carry known-flagged versions and the gate will be red on master by design. If that's awkward, land #429 first and this can merge immediately after — or flip to advisory-only and back once clean.
Trade-offs stated plainly
cargo install cargo-audit --lockedcosts a few minutes per run (no cache configured — kept deliberately simple; aSwatinem/rust-cache-style step can be added later if the runtime matters).