Repository navigation
Conversation
marySalvi
force-pushed
the
include-FFW-build
branch
from
September 16, 2026 18:44
01f0b98 to
0b42eef
Compare
bnmajor
reviewed
Sep 25, 2026
|
|
||
| # TODO: Points to forked repo and should be changed/removed when merged | ||
| RUN git clone https://github.com/caitlinross/codes.git opt/FFW \ | ||
| && cd opt/FFW \ |
Collaborator
There was a problem hiding this comment.
Lets use an absolute path here to avoid potential issues if WORKDIR ever changes.
Suggested change
| && cd opt/FFW \ | |
| && cd /opt/FFW \ |
Comment on lines
+68
to
+72
| RUN cmake -S opt/FFW -B opt/FFW/build/local \ | ||
| -DROSS_DIR=/ross/install/lib \ | ||
| && cmake --build opt/FFW/build/local -j"$(nproc)" \ | ||
| --target model-net-fluid-flow-wan-random-traffic \ | ||
| model-net-fluid-flow-wan-trace-traffic |
Collaborator
There was a problem hiding this comment.
Suggested change
| RUN cmake -S opt/FFW -B opt/FFW/build/local \ | |
| -DROSS_DIR=/ross/install/lib \ | |
| && cmake --build opt/FFW/build/local -j"$(nproc)" \ | |
| --target model-net-fluid-flow-wan-random-traffic \ | |
| model-net-fluid-flow-wan-trace-traffic | |
| RUN cmake -S /opt/FFW -B /opt/FFW/build/local \ | |
| -DROSS_DIR=/ross/install/lib \ | |
| && cmake --build /opt/FFW/build/local -j"$(nproc)" \ | |
| --target model-net-fluid-flow-wan-random-traffic \ | |
| model-net-fluid-flow-wan-trace-traffic |
| # of relying on a host `ross` checkout bind-mounted at runtime. | ||
| COPY --from=ross-builder --chown=vscode:vscode /ross/build/models/phold/phold /opt/ross/phold | ||
| COPY --from=ross-builder --chown=vscode:vscode /opt/codes /opt/codes | ||
| # TODO: This may change once the FFW changes land in the main repo |
Collaborator
There was a problem hiding this comment.
Can we add a short comment here about why we are copying everything over instead of just a subset of the repo? We may want to also consider an issue to come back to this and determine if we can determine the minimal requirements and copy those only.
marySalvi
force-pushed
the
include-FFW-build
branch
2 times, most recently
from
September 26, 2026 21:45
016f17a to
dbeda74
Compare
marySalvi
force-pushed
the
include-FFW-build
branch
from
October 20, 2026 20:26
dbeda74 to
2687b0d
Compare
marySalvi
force-pushed
the
include-FFW-build
branch
from
October 20, 2026 20:41
2687b0d to
e3239d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173
This adds the FFW build to the container. Note the git ref points to a forked version of the CODES repo which is why it has to remain separate from the CODES git ref for now.