Skip to content

Tests: Fix testFilterSubscribersPagination pagination assertions - #162

Open
n7studios wants to merge 1 commit into
masterfrom
tests-filter-subscribers-pagination
Open

n7studios wants to merge 1 commit into
masterfrom
tests-filter-subscribers-pagination

Conversation

@n7studios

Copy link
Copy Markdown
Contributor

Summary

Fixes testFilterSubscribersPagination, which now fails consistently.

After paging forward with after_cursor and then back with before_cursor, the test asserted has_previous_page: true and has_next_page: false on page 1. The /v4/subscribers/filter endpoint now correctly returns has_previous_page: false and has_next_page: true. That matches GET /v4/subscribers and every other pagination test.

This is an API-side behaviour change. The assertions are unchanged since filter_subscribers() was added and used to pass.

Testing

Existing tests pass.

Checklist

@n7studios n7studios self-assigned this Oct 26, 2026
@n7studios n7studios added the bug label Oct 26, 2026
@n7studios
n7studios requested review from a team, ciccio-kit and noelherrick and removed request for a team October 27, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant