Skip to content

feat(SDK-554): expose IterableConfig.enableForegroundCriteriaFetch - #924

Merged
jferrao-itrbl merged 4 commits into
feature/SDK-548-uua-feature-parityfrom
feature/SDK-554-enable-foreground-criteria
Oct 14, 2026
Merged

jferrao-itrbl merged 4 commits into
feature/SDK-548-uua-feature-parityfrom
feature/SDK-554-enable-foreground-criteria

Conversation

@jferrao-itrbl

@jferrao-itrbl jferrao-itrbl commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

📝 Summary

Expose IterableConfig.enableForegroundCriteriaFetch and wire it through iOS/Android Serialization for UUA parity (SDK-548).

🎟️ Jira Ticket: SDK-554

📖 Description

Adds IterableConfig.enableForegroundCriteriaFetch (default true) so RN apps can disable unknown-user targeting criteria fetch on foreground, matching native SDK behavior. Includes toDict() serialization and bridge mapping on iOS (Serialization.swift) and Android (Serialization.java). No TurboModule/codegen changes.

🧪 How to test?

  • yarn typecheck && yarn test
  • Initialize with config.enableForegroundCriteriaFetch = false and confirm native config receives the value (native SDK logging or breakpoint in Serialization).

🧾 Changelog

Unreleased entry added in CHANGELOG.md.

📹 Loom recording if applicable

N/A

🐞 Github Issues solved

N/A

📚 Docs PR if applicable

N/A

Wire through iOS and Android Serialization for UUA foreground criteria fetch.
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Lines Statements Branches Functions
Coverage: 72%
71.99% (581/807) 61.22% (229/374) 67.18% (174/259)

@qltysh

qltysh Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Qlty


Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
New file Coverage rating: A
src/core/classes/IterableConfig.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Cover toDict() when enableForegroundCriteriaFetch is false.
Remove duplicate default assert from embeddedManager tests.
@jferrao-itrbl
jferrao-itrbl marked this pull request as ready for review October 12, 2026 14:42
@jferrao-itrbl
jferrao-itrbl requested a review from a team as a code owner October 12, 2026 14:42

@rtlsilva rtlsilva left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. LGTM

…4-enable-foreground-criteria

Resolve CHANGELOG and Iterable.test.ts conflicts for SDK-554 and SDK-553.
@jferrao-itrbl
jferrao-itrbl merged commit 964a03e into feature/SDK-548-uua-feature-parity Oct 14, 2026
11 checks passed
@jferrao-itrbl
jferrao-itrbl deleted the feature/SDK-554-enable-foreground-criteria branch October 14, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants