Repository navigation
Make the engine's static limits overridable from the build - #1
Merged
Merged
Conversation
Wrap MAX_STACK, MAX_RSTACK, MAX_WORD_LEN, MAX_WORDS, MAX_INPUT and MAX_DICT_CODE in #ifndef so a consumer can size the dictionary, code space and stacks with -D flags. Defaults are unchanged. Motivation: on an ESP32-S3 without PSRAM the default arrays cost ~57 KB of internal RAM, which does not fit beside a TLS stack. With -DMAX_WORDS=160 -DMAX_WORD_LEN=24 -DMAX_DICT_CODE=1536 the engine takes ~14 KB (measured in the Diana Cardputer host project). Verified: esp32c3_release with defaults (66,928 B RAM, 177,724 B flash, unchanged) and esp32s3_release with the reduced limits (28,948 B RAM). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap MAX_STACK, MAX_RSTACK, MAX_WORD_LEN, MAX_WORDS, MAX_INPUT and MAX_DICT_CODE in #ifndef so a consumer can size the dictionary, code space and stacks with -D flags. Defaults are unchanged.
Motivation: on an ESP32-S3 without PSRAM the default arrays cost ~57 KB of internal RAM, which does not fit beside a TLS stack. With -DMAX_WORDS=160 -DMAX_WORD_LEN=24 -DMAX_DICT_CODE=1536 the engine takes ~14 KB (measured in the Diana Cardputer host project).
Verified: esp32c3_release with defaults (66,928 B RAM, 177,724 B flash, unchanged) and esp32s3_release with the reduced limits (28,948 B RAM).