Repository navigation
fix: nav highlight, voted-action metadata errors and IP redaction for v3.0.0 - #4298
Merged
Merged
Conversation
The parent of the Proposals, Live Voting and Historical links now shows as active whenever findActiveNavTo matches one of its children, in the top bar, the dashboard sidebar and both mobile menus. Link honours its isActive override even with an empty navTo, and FakeLink and DrawerLink take one.
The details card hid the metadata error and its fetch report once the wallet had voted on the action or while its vote was in progress. The action's metadata fails the same either way, so the card no longer passes the vote state to DataMissingInfoBox.
The metadata routes and error bodies built from data-layer errors send IPv4 addresses as 203.xx.xx.45 and IPv6 addresses with only their first and last group. Document bodies, urls, ids and hashes are left as the service sent them. Amends D116.
mesudip
force-pushed
the
fix/nav-highlight-diagnostics-ip-redaction
branch
from
October 18, 2026 18:18
dc0a4e7 to
761e09c
Compare
sireto-sandip
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes
203.xx.xx.45(D171)Meant for v3.0.0: promote to
testandmainbefore the tag is cut.Checklist