Repository navigation
Make profiling optional in service-reuse campaigns - #521
jiangkuaixue123 merged 5 commits into
Conversation
david6666666
left a comment
There was a problem hiding this comment.
A bounded supplemental profile can still make the authoritative round unreadable.
zengchuang-hw
left a comment
There was a problem hiding this comment.
PASS
首次独立检视,范围为 #513 已接受的设计。正式评估在 inline capture 前持久化,核实清理后从 checkpoint 恢复,不重跑测量;profiling 不参与 verdict/选优。预算按 capture ID 幂等结算,缺结束凭据仅返还已证明时长,单有起点返还零秒;调整后时间用于准入及执行,final reserve 不变。backfill 定位最后已结算 PASS/FAIL,独立路径/索引,失败不丢旧 profile 或改写旧 verdict。新增回归覆盖中断和重复恢复、锁/清理以及损坏证据等边界。未发现批准前必做项。
静态核对了 17 个文件和回归代码。作者的本地 CPU 合成服务结果不代表真设备或全量套件;我未运行代码、测试或查询 CI。本结论不改变 Draft,也不等于 #513 整体验收。
检视 head:586c56e4bb8676a84a569afd24262c862ec7aed6。
cb4c91c to
9fa23fb
Compare
|
Posted by an agent on behalf of @Dong1017 (incremental review only; points already raised by others are not repeated). DO NOT PASS — reviewed head Blocking
Non-blocking
Scope checked: the full |
zengchuang-hw
left a comment
There was a problem hiding this comment.
PASS
增量检视 586c56e4bb8676a84a569afd24262c862ec7aed6 → 2786151d681af2d1362233d1789bcf9495c2e01f。对照 上轮检视 和 #513。
新记录不再把大体积 profiler receipt 重复嵌入观察与引用,仍能按路径回读并核验原始 receipt、配置、服务绑定、完成状态及区间。32 KiB 上限只限制新增区间和 artifact 元数据。旧的大体积记录仍可通过逐字流式比对进入后续轮次和 final,不改写历史原件;补充 profile 仍不计入性能或质量裁决。回归用例覆盖大 receipt、大配置、超限元数据保留旧捕获、旧记录继续运行和篡改拒绝。
批准前必做:无。已静态核对变更与回归用例,未执行代码、测试或实机捕获。本检视不改变 Draft 状态,也不代表 #513 的完整验收。
|
基于
如果希望分批交付,可以先独立审查“正式结果先落盘、profile 失败后恢复原判、后续选优和 final 只依赖必需证据”,再分别审查 screening、预算恢复和历史补采,最后按 #513 的完整要求验收。本次反馈来自代码与测试源码阅读,未重跑测试。 |
Signed-off-by: lirx-pd <616517220@qq.com> Agent-assisted-by: Codex / gpt-6.2-astra [effort=xhigh] (author)
Signed-off-by: lirx-pd <616517220@qq.com> Agent-assisted-by: Codex / gpt-6.2-astra [effort=xhigh] (author)
Signed-off-by: lirx-pd <616517220@qq.com> Agent-assisted-by: Codex / gpt-6.2-astra [effort=xhigh] (author)
Signed-off-by: lirx-pd <616517220@qq.com> Agent-assisted-by: Codex / gpt-6.2-astra [effort=xhigh] (author)
Signed-off-by: lirx-pd <616517220@qq.com> Agent-assisted-by: Codex / gpt-6.2-astra [effort=xhigh] (author)
2786151 to
47239e4
Compare
|
@jiangkuaixue123 Thanks for the review. Inline and backfill profile reads now share the same validator. Backfill still verifies the target attempt, capture instance, and publication index. The tests now cover optional profile loss separately from required evidence loss, with distinct recovery cases for interruptions during capture, before index publication, and after publication. New selection records reference the original attempt by ID. CLI and dashboard output reconstruct the original inline profile, while round availability reflects the latest usable backfill. Existing campaign records remain readable. On WSL, 109 tests and 43 subtests passed, along with Ruff and |
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 493416520f537590eb8f2a4e74f276f82e488307 and head 47239e4864b3a3694dd7320d50852922bdd75233.
Independent third-party verify of tip (zengchuang-hw Approves on earlier heads are dismissed after tip moved). Scope: #513 — profiling optional / supplemental for service_reuse campaigns.
Verified:
- Formal performance/quality stay authoritative; profile capture is optional, bounded (
PROFILE_METADATA_LIMIT), and does not duplicate large receipts into campaign records (addresses prior inline concern). - Tip commits keep selection profiles resolved from original attempts (
service_observations.selection_view/reference_view) instead of embedding mutable profile blobs in selection snapshots. - Local targeted:
test_project_service_reuse+ service backfill/capture/profile/reference suites → 128 passed. - Ready CI green on tip (full-check 3.10/3.11, declarations, installed-package, dashboard-browser, pr-references).
Eligibility: cursor[bot] collaborator permission is none. This Approve is technical/third-party verify only — not a write+ eligible Approver under docs/agent-collaboration.md, and not a claim that dual tip / merge-ready is satisfied. Merge still needs a write+ independent Approve and steward integration.
Governing Issue and delivery slice
Refs #513
service_reuse. @Dong1017 accepted the scope and assigned delivery coordination to @lirx-pd. Issue decisionKnowledge authorship declaration
Changed artifacts and evidence
FAIL.test_project_service_reuse.pycovers screening rejection, script error, missing formal evidence and valid gate failures.availableand the campaign-relative receipt and artifact paths when usable. The agent receives the failed stage, a bounded excerpt and available details or log paths. Full collector output stays in its receipt. The 32 KiB limit applies to the encoded capture interval and artifact locations.test_service_profile_diagnostics.pycovers large receipts and configurations, invalid captures and fallback to usable evidence.inferrsi campaign profile --session <campaign> --round <number>starts a fresh service for the last settledPASSorFAILattempt. Publication requires validated artifacts and verified cleanup. Round availability uses the latest valid capture. Selection records resolve the original inline profile by attempt ID, including when reading historical records.Inline capture runs when configured after either a formal performance rejection or a combined performance and quality pass. A quality rejection settles as
FAILand skips capture. Missing required evaluation evidence yieldsINCONCLUSIVE. The CLI contract, exit codes and recovery examples are indocs/service-reuse-campaigns.md. The command is also listed indocs/operations.md.Checks and dependencies
git diff --checkpassed.sampling.profile_timeout_secondsdefaults tosampling.stage_timeout_seconds. A conclusive final after a condition change still requires a candidate accepted under the new conditions.Remaining work and Issue closure
@Dong1017 owns the repository acceptance decision for #513. Scope and ownership
Handoff (only when an actual handoff or decision changed)