Skip to content

refactor(knowledge): unify search on Find and archive its evidence - #507

Merged
jiangkuaixue123 merged 17 commits into
InferMatrixLab:mainfrom
jiaran-king:codex/unify-knowledge-discovery
Nov 19, 2026
Merged

jiangkuaixue123 merged 17 commits into
InferMatrixLab:mainfrom
jiaran-king:codex/unify-knowledge-discovery

Conversation

@jiaran-king

@jiaran-king jiaran-king commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Refs #316 (search follow-up to #466) and #384 (search archive).

What changed

  • Use one local Find ranking implementation for new text discovery, including the managed project and benchmark flows. Keep legacy command names for compatibility, filtered catalog inspection and exact/budgeted assembly; text queries through those wrappers use Find ranking rather than another search algorithm.
  • Import direct find and read activity through the existing campaign search archive. Distinguish search hits, delivered passages and supported use in a round decision. Missing or unusable evidence does not silently turn into a complete zero-search record.
  • Keep historical archives and saved captures readable without re-running search. Preserve the external provider boundary and the upstream Apps handoff module layout.

Validation

  • Ruff and diff checks; targeted search, compatibility, managed session, archive, citation, and module-migration tests on current main; isolated DSH package and loopback fixture checks.
  • A real local CPU Codex optimization round read two Cases. The archive linked one delivered passage to a cited decision and left the other as unknown. This verifies the evidence path, not an optimization speedup.
  • This is a draft. No browser interaction, Windows replay or NPU performance claim is made.

Knowledge authorship declaration

The contributor verified the effective runtime settings. The two trailers that previously recorded GPT-6.1 Sol have been corrected to GPT-6.2 Sol at max effort.

{
  "schema_version": 1,
  "head_sha": "d0f83b954f190c07f669a6fbf569bd6d879e8f44",
  "human_only": false,
  "material_ai_authors": [
    {
      "tool": "Codex",
      "model_id": "gpt-6.2-sol",
      "effort": "max",
      "role": "author"
    }
  ]
}

Use Find to rank managed knowledge questions before collecting pinned,
budgeted context. Resolve installed entries inside each runtime so base
installations and DSH can follow a hit to the original material.
Retain exact catalog and explicit legacy operations for existing callers.

Agent-assisted-by: Codex (managed discovery, readback and DSH implementation)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
Agent-assisted-by: Codex / gpt-6.2-sol [effort=max] (Case backend metadata)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
Rank the eligible kind corpus, open packaged skills without the optional YAML parser, and use authored Case backend scope. Retain legacy catalogue and dual-cue selectors. Allow exact installed Case capture and record the actual discovery sources.

Agent-assisted-by: Codex (implementation and capture regression coverage)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
Reuse the Find corpus and ranker for package catalog queries, grouped research, Collect and optional context files. Preserve exact inventory, pinned reads, budgeted delivery and historical archives. Document legacy input migration and cover external-only public results.

Agent-assisted-by: Codex / gpt-6.2-sol [effort=max] (catalog, Collect and protected guidance)
Agent-assisted-by: Codex (CLI, applications and verification)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
Limit package-only Store discovery to reserved package projections and store-owned candidates so every hit can be opened by the same reader.

Agent-assisted-by: Codex / gpt-6.2-sol [effort=max] (implementer)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
Assert the retired scorer names stay absent while preserving the historical move manifest and surviving APIs. Regenerate the synthetic dashboard example with the recorded Find scores and call chain.

Agent-assisted-by: Codex (compatibility assertions and fixture regeneration)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
Distinguish ranked references, verified resource delivery and reviewed use. Keep incomplete or unsupported CLI returns visible without asserting complete search totals.

Agent-assisted-by: Codex (direct retrieval trace import and regression verification)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
Classify exact reads and queryless inventories from the recorded selection. Match complete managed JSON returns to their verified captures before recording delivered resources.

Agent-assisted-by: Codex (capture classification and archive delivery)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
Handle the continued read command shown in the dashboard guide without treating separate shell commands as one return.

Agent-assisted-by: Codex (shell decoding and end-to-end regression)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
Resolve explicit references in existing optimization reasons through the saved round receipt and the reviewed search archive. Keep unverified use as a declaration.

Agent-assisted-by: Codex (round evidence integration and independent review)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
Keep the upstream handoff package layout and apply installed skill context delivery at its canonical location.

Agent-assisted-by: OpenAI dot (merge integration and validation)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Skill evaluation

PLANNED: not executed; there are no task outcomes yet.
No approval, model efficacy or current-head test result is implied.

  • Next: run the pinned source/index --check below at head d0f83b954f190c07f669a6fbf569bd6d879e8f44.
  • Task selection: no supported automatic comparison; choose a relevant source/content check and disposition uncovered claims.
  • Selected comparisons: 0 · Estimated task calls: 0. Uncovered/unsupported changes: 82; Canonical library paths: 7; Generated projection paths: 3; Other paths: 72. These are paths, not independent claims.
  • Return: command, input/source pin, exit status, outputs/failures and untested claims for independent verified/refuted/unverified disposition.
Author verification steps (nonpaid; not yet run)
  1. Bind the checkout. Run git rev-parse HEAD; it must equal d0f83b954f190c07f669a6fbf569bd6d879e8f44. If it differs, obtain a current plan; do not reuse old results.
  2. Check source/index consistency. At that PR checkout, using the reviewed repository tool and its documented development dependencies, run:
python tools/build_skill_index.py --source-revision 14e6f17bd254aaa05da0d5a2e3aea35ed337b139 --check

The declared source pin matches this head's canonical library bytes. The command has not run: retain its exit code and full drift/success output. It checks the generated projection, not claim truth or skill efficacy.
No supported automatic comparison is selected. Review the canonical changes and explain which claims need evidence, are unaffected, or remain unverified; do not treat generated records as separate behavioral claims.
Uncovered scope by location: Canonical library paths: 7; Generated projection paths: 3; Other paths: 72. Path counts are not claim counts; no metadata-only conclusion is inferred.
3. Return evidence for independent review: head, check/task/source pin, command, environment, exit status, outputs/failures and untested claims. Label scripted controls. Request each claim's disposition: verified, refuted or unverified; this plan proves neither model provenance nor benefit.
Check recipes and evidence limits

Evidence and logs · Retention: 30 days.
Retained artifacts are verifiable only before Unix time 1797662680 while the linked artifact is available. Expired evidence is unverified.

Plan bindings, budget, frozen exam and advisory details

Advisory: obtain missing evidence

Retained evidence availability: planned / unexecuted. No approval or merge authorization is issued.
Applicable only while these revisions and inputs match the current PR.
Paid execution requires trusted label authorization and cumulative PR reservation. Unknown accounting blocks new paid calls; planning is not execution.
Pipeline evidence only; offline fixed outputs do not establish skill efficacy.
Unchanged-correct is valid neutral evidence, not incremental benefit.
Content/source review and authorship admission remain separate.
Trusted regrading checks retained answers, not model/hardware provenance or a hostile executor; this is not an efficacy certification.

  • Retained evidence is planned / unexecuted.
  • No supported comparison cases were selected.
  • Uncovered/unsupported scope needs a case or explicit reviewer disposition.
    Plan SHA-256: 3b3bba923a5dfb67baa1889e1aa2801dcebca90c7ef639f6ead677806b18ffe1
    Base: 9b81c9ba1d4d1f7d45bd039a7c02ac2f01859426 · Head: d0f83b954f190c07f669a6fbf569bd6d879e8f44
    Trusted implementation: 9b81c9ba1d4d1f7d45bd039a7c02ac2f01859426

Model/settings: {"effort":"not_applicable","name":"claude-opus-5-5"}
Budget: {"comparisons":0,"estimated_calls":0,"limits_per_comparison":{"campaign_seconds":600,"max_task_calls":2,"repeats":1,"timeout_seconds":180,"token_stop_new_trials":200000},"provider_config_sha256":"b28d80f8194fbe0f5a9f01515efb24b218979fd45f702776560da276f4b30d04","reservation":null}

Skill Comparison Cases Estimated calls

Automatic execution / cumulative PR budget:

{"reason":"Trusted configuration or pricing missing, invalid or expired","remaining_usd":"unknown","reserved_or_unresolved_usd":"unknown","spent_or_legacy_usd":"unknown","state":"blocked"}

Projection check selection (not an executed result):

{"declared_in":"src/inferrsi/knowledge/data/repo_packs/inferrsi/knowledge/_provenance.json","source_revision":"14e6f17bd254aaa05da0d5a2e3aea35ed337b139","status":"ready"}

Provider/settings: {"client":{"api_version":"2023-06-01","endpoint":"https://yibuapi.com/v1/messages","kind":"anthropic-messages-full-context-v1","max_output_tokens":4096,"max_read_bytes":32768,"max_request_bytes":262144,"max_requests":1,"max_tool_calls":12,"provider":"yibuapi"},"limits":{"token_stop_new_trials":200000},"model":{"effort":"not_applicable","name":"claude-opus-5-5"},"pricing":{"currency":"USD","expires_at":1793271228,"group":"default","max_input_tokens":1000000,"model":"claude-opus-5-5","rate_evidence":"https://github.com/InferMatrixLab/InferRSI/issues/215#issuecomment-6467531341","rates":{"cache_read":"0.4","cache_write":"10","input":"8","output":"40"},"request_fee":"0","unit":"per_million_tokens"},"spend_limit":{"amount":"200","currency":"USD"}}

Uncovered / unsupported paths (82)
  • uncovered: "CHANGELOG.md"
  • uncovered: "docs/contracts/README.md"
  • uncovered: "docs/contracts/dto-field-index.md"
  • uncovered: "docs/contracts/fixtures/README.md"
  • uncovered: "docs/contracts/fixtures/pattern-boundary-cases.json"
  • uncovered: "docs/contracts/schema-and-semantics.md"
  • uncovered: "docs/contracts/schemas/contract-v1.schema.json"
  • uncovered: "docs/dashboard.md"
  • uncovered: "docs/dsh-plugin.md"
  • uncovered: "docs/examples/dashboard-profile-review.html"
  • uncovered: "docs/knowledge-base.md"
  • uncovered: "docs/knowledge-operations.md"
  • uncovered: "docs/knowledge-retrieval-trace.md"
  • uncovered: "docs/knowledge-store.md"
  • uncovered: "docs/operations.md"
  • uncovered: "docs/optimization-workflow-unification.md"
  • uncovered: "docs/quickstart.md"
  • uncovered: "docs/service-reuse-campaigns.md"
  • uncovered: "plugins/inferrsi-dsh/remote.cjs"
  • uncovered: "plugins/inferrsi/skills/inferrsi/SKILL.md"
  • uncovered: "plugins/workswarm/inferrsi/skills/inferrsi/SKILL.md"
  • uncovered: "pyproject.toml"
  • uncovered: "src/inferrsi/apps/campaign.py"
  • uncovered: "src/inferrsi/apps/cli/init.py"
  • uncovered: "src/inferrsi/apps/cli/arguments.py"
  • uncovered: "src/inferrsi/apps/handoff/context_provider.py"
  • uncovered: "src/inferrsi/apps/knowledge.py"
  • uncovered: "src/inferrsi/apps/views/capture_delivery.py"
  • uncovered: "src/inferrsi/apps/views/codex_knowledge.py"
  • uncovered: "src/inferrsi/apps/views/codex_search.py"
  • uncovered: "src/inferrsi/apps/views/codex_tool_returns.py"
  • uncovered: "src/inferrsi/apps/views/retrieval_projection.py"
  • uncovered: "src/inferrsi/apps/views/round_citations.py"
  • uncovered: "src/inferrsi/apps/views/search_archive.py"
  • uncovered: "src/inferrsi/apps/views/search_attribution.py"
  • uncovered: "src/inferrsi/knowledge/_skill_selection.py"
  • uncovered: "src/inferrsi/knowledge/catalog.py"
  • uncovered: "src/inferrsi/knowledge/data/repo_packs/inferrsi/knowledge/_provenance.json"
  • uncovered: "src/inferrsi/knowledge/data/repo_packs/inferrsi/knowledge/common/skills/inference-optimization-casebook.json"
  • uncovered: "src/inferrsi/knowledge/data/repo_packs/inferrsi/knowledge/common/skills/kernel-writing-guide.json"
  • uncovered: "src/inferrsi/knowledge/data/skill_library/methods/inference-optimization-casebook/cases/admission-drain-occupancy.json"
  • uncovered: "src/inferrsi/knowledge/data/skill_library/methods/inference-optimization-casebook/cases/drama3-rejected-directions.json"
  • uncovered: "src/inferrsi/knowledge/data/skill_library/methods/inference-optimization-casebook/cases/qwen-ascend-rejected-directions.json"
  • uncovered: "src/inferrsi/knowledge/data/skill_library/methods/inference-optimization-casebook/cases/qwen-b300-rejected-directions.json"
  • uncovered: "src/inferrsi/knowledge/data/skill_library/methods/kernel-writing-guide/cases/vllm-gdn-source-contract.json"
  • uncovered: "src/inferrsi/knowledge/data/skill_library/workflows/inference-engine-research/SKILL.md"
  • uncovered: "src/inferrsi/knowledge/data/skill_library/workflows/inference-engine-research/references/model-aware-preparation.md"
  • uncovered: "src/inferrsi/knowledge/knowledge_find.py"
  • uncovered: "src/inferrsi/knowledge/knowledge_operations.py"
  • uncovered: "src/inferrsi/knowledge/research.py"
  • uncovered: "tests/check_dsh_remote.cjs"
  • uncovered: "tests/check_installed.py"
  • uncovered: "tests/fixtures/indexer/README.md"
  • uncovered: "tests/fixtures/knowledge_retrieval.py"
  • uncovered: "tests/test_apps_context_provider.py"
  • uncovered: "tests/test_architecture_closed_loop.py"
  • uncovered: "tests/test_campaign_record_injection.py"
  • uncovered: "tests/test_campaign_task_selection.py"
  • uncovered: "tests/test_cannbot_boundaries.py"
  • uncovered: "tests/test_codex_knowledge_search.py"
  • uncovered: "tests/test_collect_selection.py"
  • uncovered: "tests/test_contract_schema_patterns.py"
  • uncovered: "tests/test_dsh_plugin.py"
  • uncovered: "tests/test_knowledge_cli.py"
  • uncovered: "tests/test_knowledge_compatibility_shells.py"
  • uncovered: "tests/test_knowledge_find.py"
  • uncovered: "tests/test_knowledge_install.py"
  • uncovered: "tests/test_knowledge_navigation_browser.py"
  • uncovered: "tests/test_knowledge_operations.py"
  • uncovered: "tests/test_knowledge_store.py"
  • uncovered: "tests/test_optimization_session.py"
  • uncovered: "tests/test_optimization_story.py"
  • uncovered: "tests/test_project_optimization.py"
  • uncovered: "tests/test_project_service_reuse.py"
  • uncovered: "tests/test_raw_string_selection.py"
  • uncovered: "tests/test_research.py"
  • uncovered: "tests/test_retrieval_projection.py"
  • uncovered: "tests/test_round_citations.py"
  • uncovered: "tests/test_search_archive.py"
  • uncovered: "tests/test_search_capture_delivery.py"
  • uncovered: "tests/test_skill_library.py"
  • uncovered: "tools/evaluate_indexer.py"

@zengchuang-hw zengchuang-hw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO PASS

Draft PR #507, head 07ace74ebe4534e98dbf60485aff0b2e045c59f2. Scope: Find migration (#316) and search archive (#384).

  1. Repeated decision reason can lose valid citation evidence. round_citations.py:165–167 picks the first assistant occurrence of the logged reason. If the same reason appears before and after a visible read, round_reviews.py:179–182 discards the read and leaves adoption unknown despite the later valid sequence. Pair the read with a qualifying decision before the saved log and cover the repeated-reason case in a regression test. Preserve the guard against crediting reads after the decision.
  2. Exact-head knowledge declaration failed. The declaration log reports a missing, invalid, or stale declaration for this head. Correct the declaration and verify the resulting head.

I reviewed the Find ranking and callers, compatibility wrappers, Apps evidence paths, and relevant tests statically. No additional confirmed blocker in the Find code. Ready CI was still running at inspection; repository tests and the author’s CPU round were not rerun locally. This is the first review of this draft.

@Dong1017 Dong1017 added kind:task Bounded delivery task with a delegated slice area:knowledge Knowledge line: packs, skill library, knowledge admission labels Nov 19, 2026

@david6666666 david6666666 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static review of the Find migration and search-archive integration at 07ace74e. I did not rerun the tests.

return None, not in_scope, None
code, output = item.get("exit_code"), item.get("aggregated_output")
if call := knowledge_invocation(argv):
return decode_knowledge(call, code, output)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A successful campaign knowledge or benchmarks session knowledge call falls through as unrelated here. If its capture ID is omitted, import-search --complete can report zero searches with complete coverage even though the rollout contains a managed query. Could we keep coverage partial unless the query is matched to a verified capture, and add a regression where the capture ID is omitted?

Comment thread docs/operations.md Outdated
| Execute one ordinary local CPU command with a fixed record | Python `inferrsi.harness.api.Harness.allocate` / `execute` / `read` | Experiment-executing / record-writing | One explicit RunStore root and one trusted local CPU target; ordinary command mode only; a record holds execution facts, so exit 0 is not a verdict; no device, model or network fallback |
| Visualize a recorded run or campaign | CLI `dashboard`; [dashboard](dashboard.md) | Report-generating / local read-only serving | Writes an offline HTML snapshot or serves an optional live view on loopback; does not run an agent or validate a claim |
| Capture a knowledge context | CLI `campaign capture-context`; [offline dashboard](dashboard.md#record-the-optimization-story-campaign-trace) | Local evidence-writing | Runs `collect` with a context budget and keeps the full envelope and resource hashes in a new `knowledge/<id>.json`; proves what was prepared, not what a model read |
| Capture a knowledge context | CLI `campaign capture-context`; [offline dashboard](dashboard.md#record-the-optimization-story-campaign-trace) | Local evidence-writing | Saves assembled context and resource hashes in a new `knowledge/<id>.json`. Uses Find for ordinary questions and supports explicit IDs and legacy ranking options |

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This row promises support for legacy ranking options, but capture-context rejects the old --relevance-method values, and the migration section below tells callers to remove them. Please clarify that the flag spelling remains but find-lexical-v1 is the only accepted value. The Collect row has the same mismatch.

@david6666666 david6666666 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One separate delivery-versus-use case on the same head.

trace, lines, knowledge_root, archive=True, selections=selections)
trace, lines, knowledge_root, archive=True, selections=selections, **options)
capture_returns = dict(review["capture_returns"])
if note_line is not None:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we match selected capture returns whenever the trace window is available, even if the round reason has no [use …] citation? With a valid capture ID and an exact tool response, this branch still leaves delivery unknown solely because no citation was written. The return should count as visible delivery while adoption stays unknown. Please cover an uncited managed return with a supplied capture ID.

Match saved captures against their managed tool returns and retain every instance of a manual reason uttered before the saved log. Document the supported Find ranking value.

Agent-assisted-by: Codex (archive implementation and regression tests)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
Use the committed library snapshot containing the revised research guidance. Running the index and coverage generators changes only the shared source revision.

Agent-assisted-by: Codex (generated skill projection refresh)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
Keep the service lifecycle and fingerprint-free package context. Use the existing package Find corpus and ranker for service knowledge, with one supported method across managed entrypoints.

Agent-assisted-by: Codex (merge resolution and service knowledge integration)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
Use the shared capture verification for text queries. Exact IDs and inventory remain non-search operations. Preserve the distinction between a saved capture receipt and visible material.

Agent-assisted-by: Codex (archive coverage and regression tests)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
Agent-assisted-by: Codex / gpt-6.2-sol [effort=max] (skill projection regeneration)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
@jiaran-king
jiaran-king force-pushed the codex/unify-knowledge-discovery branch from 07ace74 to 871c39d Compare November 19, 2026 03:46

@david6666666 david6666666 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prior coverage, uncited-delivery and legacy flag points are addressed. One new exact-head CI regression below.

captures = {key: capture_event(key, capture_inputs[key]) for key in capture_ids}
trace, lines, knowledge_root, archive=False, **options)
return_texts = capture_return_texts(trace, lines, capture_returns, capture_ids)
captures = {key: capture_event(key, capture_inputs[key], return_chunks=return_texts.get(key),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now adds verified capture delivery to the local record, but the generated profile example is still from the previous shape. Both Ready full-check jobs fail test_published_profile_example_matches_fixture on HTML equality. Please regenerate docs/examples/dashboard-profile-review.html with tests/fixtures/dashboard_profile_review.py after the archive changes and keep the equality check.

Agent-assisted-by: Codex / gpt-6.2-sol [effort=max] (generated skill projection and offline profile example)
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
zengchuang-hw
zengchuang-hw previously approved these changes Nov 19, 2026

@zengchuang-hw zengchuang-hw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PASS

Incremental independent review of 07ace74ebe4534e98dbf60485aff0b2e045c59f2 → 871c39d0812ab5e67bdf42ffb6e5e7d2e508a010, anchored to the latter. Previous review: #507 (review). Scope remains the Find migration and retrieval/archive behavior (#316 / #384).

The previous repeated-reason defect is resolved: decision_positions now retains every matching statement before the accepted log submission, and round_reviews pairs a visible source return with a later qualifying decision. A repeated pre-read/post-read reason can establish the later association, while a statement only before the read or after the saved log cannot. The regression cases now explicitly cover these orders.

I also inspected the incremental managed/manual capture paths: recognized search commands without their matching selected capture/receipt remain unresolved; delivery is recorded separately from adoption; a complete managed envelope can establish delivery without a use citation; missing, clipped or grouped/unmatched results retain partial coverage. The service-reuse integration ranks the package catalog with Find while keeping its fingerprint-free prepared-context format separate from the versioned archive importer. The related CLI/docs/tests reflect these boundaries.

The old and new histories diverge after rebasing. I compared the actual tree contents and separated inherited main changes from this PR's changes against current base 9b418d7fe16f3979b67f74f290949629ef103e8f, rather than treating a three-dot comparison as the literal incremental diff. No remaining concrete blocker found in this incremental code review; no additional prerequisite or non-blocking suggestion.

Executed checks: read-only source/tree and test-source inspection; current author/repository/head and my own prior-review deduplication. Not executed: repository code, tests, model/device experiments. CI was not queried or used as an approval condition in this round; the previous CI/declaration item is not carried forward as a code blocker under the current review instructions. This approval is a code-review conclusion, not a claim that unexecuted tests or experiments passed. No third-party review opinions were consulted.

@zengchuang-hw zengchuang-hw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PASS

独立增量检视:871c39d0812ab5e67bdf42ffb6e5e7d2e508a010 → d0f83b954f190c07f669a6fbf569bd6d879e8f44(上轮检视)。

两版提交历史已分叉,本轮直接比较完整 Git 树:仅两份文件变化,无文件删除,运行时代码和测试源未变。

  • Dashboard 合成示例现在标注 A/B 已送达、C/D/E 未知;与现有捕获记录的第 2 行返回和两条资源预算相符。采用仍为未知,used=0;E 的省略冲突记录也保留,没有把送达当作采用。
  • 知识包的 _provenance.json 仅更新来源提交。该提交的 registry blob 与当前相同,registry 哈希字段未变。

上轮 citation reason 修复未受本次改动影响;本轮无批准前必做项或新增非阻塞建议。已静态核对 Git 树、变更、相关 fixture 与交付判定代码,以及 #384 的适用要求;未执行仓库代码、测试或实验,未查 CI。此批准仅针对所列 head 的代码检视,不改变 Draft 状态。

@jiaran-king
jiaran-king marked this pull request as ready for review November 19, 2026 06:44

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR review verdict — PASS
Reviewed base 9b81c9ba1d4d1f7d45bd039a7c02ac2f01859426 and head d0f83b954f190c07f669a6fbf569bd6d879e8f44.

Second tip technical verify after zengchuang-hw tip Approve on the same head.

Verified:

  • Find ranking remains the shared text-discovery path; capture/search archive distinguishes hits, delivered passages, and used citations without treating delivery as adoption
  • Tip regenerations refresh skill projection / offline profile example; test_published_profile_example_matches_fixture passes locally (addresses prior Ready HTML mismatch thread)
  • campaign knowledge / benchmarks session knowledge decode as captured_search with complete=False until a verified capture match — open suggestion about omitted capture IDs does not reproduce as a tip false-complete blocker on this head; optional follow-up for an explicit regression remains non-blocking
  • Local targeted knowledge/search suites: 274 passed, 2 skipped; ruff clean on touched Find/archive modules
  • Ready 44474326319: full-check 3.10/3.11, installed-package, dashboard-browser, hosts, pr-references success; declarations pass

Technical/third-party verify only (cursor[bot] permission none). Not a write+ eligible Approver claim; not dual-tip / merge-ready under agent-collaboration. Merge still needs write+ independent Approve — left to Dong always-on / write+ humans. Note #515 integration order with overlapping knowledge surfaces if stacked with #516.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:knowledge Knowledge line: packs, skill library, knowledge admission kind:task Bounded delivery task with a delegated slice

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants