Fix omitzero handling - #28
Merged
Merged
Conversation
satvik007
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
isOptionalnow marks struct fields taggedomitzeroas optional. This includestime.Timeand inline structs. Struct fields tagged onlyomitemptystay required.hasJSONOption, reads the options of ajsontag. Before this change, the code usedstrings.Containson the whole tag.isOptionalandisNullableboth use the new helper.getValidateKeysnow usesstrings.Cutinstead ofSplitN. This is a small cleanup with no change in behavior.omitzeroon structs,time.Time,*time.Time, arrays, slices, maps, pointer-to-slice/map, and fields namedomitzero/omitempty.Why
encoding/jsonomits a struct field taggedomitzerowhen the value is zero or when itsIsZero()method returns true. The old code never marked struct fields as optional, so the schema required fields that Go may leave out of the JSON.json:"omitzero"sets the field name toomitzerobut has no options, and it was still treated as optional.Impact
encoding/jsonproduces for these fields. Struct andtime.Timefields taggedomitzeronow get.optional().omitemptyoromitzerois no longer marked optional or non-nullable by mistake.omitzerowithvalidate:"required"stay required.