add module Happstack.Server.FileServe.Nix that serves files/directori… - #92
Open
cliffordbeshers wants to merge 4 commits into
Open
cliffordbeshers wants to merge 4 commits into
cliffordbeshers wants to merge 4 commits into
Conversation
…es with nix store hashes as etags so that files reload properly when they change
The previous commit added src/Happstack/Server/FileServe/Nix.hs but never listed it in Exposed-modules, so cabal never actually compiled it -- it shipped as dead code and CI never exercised it. This wires it into the build and adds the ifNoneMatch function (Response.hs) that it depends on for ETag-based conditional GETs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The GHC 9.14 CI job fails during dependency resolution: cabal picks monad-control-1.0.0.2, which unconditionally imports Control.Monad.Trans.List and Control.Monad.Trans.Error -- both removed from transformers in the 0.6 series, which is what resolves for this GHC/base combination. monad-control-1.0.3.1 guards those same imports with #if !(MIN_VERSION_transformers(0,6,0)) and is otherwise compatible with our existing bounds, so raising the floor excludes the broken releases. Verified against a live Hackage index (outside the nix package cache) that this now resolves monad-control-1.0.3.1 instead of 1.0.0.2. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…es with nix store hashes as etags so that files reload properly when they change