Repository navigation
feat(ui): name SLogic channel tiers 4 ch, 8 ch, 16 ch and 32 ch - #71
Merged
Merged
Conversation
An SLogic's rate tiers are its wire modes, which the highest enabled channel picks. They were named by their range of channels, "0–7", and a rate in the sample-rate list that needs one said "0–7 only", which does not read as the name of anything. Sipeed names these modes by their width: 4, 8, 16 and 32 ch. RateTier gains named_by_count, set by the SLogic driver alone, and the acquisition menu names such a tier by its count: "8 ch" over its rate in the tier row, and "8 ch" beside a rate that needs it, without the "≤" of a tier that takes any channels. The tooltips still say which channels a tier takes. PXLogic's and DSLogic's tiers of the first channels keep their ranges, and the mock's Stream tiers, modelled on an SLogic16U3, now go by their count too.
DESIGN.md and the user guide name the SLogic's tiers 4 ch, 8 ch, 16 ch and 32 ch, and say that a rate needing one is marked with that name.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An SLogic's rate tiers are its wire modes, chosen by the highest enabled channel. The acquisition menu named them by their range of channels: "0–3", "0–7", "0–15", "0–31". A faster rate in the sample-rate list that needs one of them was marked "0–7 only", which doesn't read as the name of anything. Sipeed's own documentation names these modes by their width: 4, 8, 16 and 32 ch.
RateTiergainsnamed_by_count, which only the SLogic driver sets. The acquisition menu names such a tier by its channel count: "8 ch" (Chinese: 「8 通道」) over its rate in the tier row, and the same "8 ch" next to a rate that needs it. There is no "≤", because that tier does not accept any 8 channels.?mocktiers=1mock's Stream tiers, modelled on an SLogic16U3, now go by their count as well.Validation:
pnpm exec eslint src,pnpm typecheck, Prettier on the changed filespnpm test: 86 files, 610 tests passed. A new case inAcquisitionMenu.test.tschecks the tier row, the rate-list note and the tooltips for tiers named by count; the existing cases still cover range-named tiers.cargo clippy --workspace --all-targets -- -D warnings;cargo testfor hsync-driver, hsync-slogic, hsync-dslogic, hsync-pxlogic, hsync-atklogic and hsync-session: 280 passed. The SLogic tier test asserts the new flag.?mocktiers=1in headless Chrome at 1440×900 in Light and Dark, Comfortable and Compact, in Chinese and English: the tier row reads 4 / 8 / 16 通道 (ch), and greyed rates read "8 通道" / "4 通道" (ch) without crowding.