Repository navigation
fix(ui): suppress browser actions in desktop windows - #66
Merged
Merged
Conversation
Prevent refresh, browser file actions, find, printing, history navigation and page zoom in both desktop windows. Run application shortcuts first so Ctrl/Cmd+S continues to save the capture, and retain native text editing menus.
Exercise browser defaults, custom shortcuts, text editing and wheel events. Verify that Ctrl/Cmd+S reaches the native waveform save flow and never falls back to saving the page when no capture is available or saving stops.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop windows currently allow unhandled browser shortcuts to refresh the interface or save the entire web page. Add shared WebView guards for the main and detached data stream windows to suppress refresh, browser file actions, printing, browser find, caret browsing, history navigation, page zoom, and page context menus outside text controls.
Application shortcuts run before the fallback guards. Ctrl/Cmd+S retains its default action of saving the current waveform as an
.hsynccapture; clearing a binding or having no capture available never enables the browser's Save Page action. Preserve custom shortcut recording, waveform wheel zoom, application context menus, and native text editing. Browser development previews retain their browser defaults. Update the design specification and user guide accordingly.Validation:
pnpm lintpnpm typecheckpnpm test— 84 files, 600 tests passedNative WebView behavior has not been manually verified on the desktop platforms.