Repository navigation
Address attendee log entry requirements review feedback - #69
Open
travismolick wants to merge 1 commit into
Open
travismolick wants to merge 1 commit into
travismolick wants to merge 1 commit into
Conversation
- Keep the cached registration levels when a refresh from ConCat fails, instead of forgetting them before refetching - Drop the redundant trim of override reasons (TrimStrings and ConvertEmptyStringsToNull already handle it) - Move the entry requirements panel into a dialog opened from the page toolbar, so the attendee and gatekeeper tables keep their height
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review comments on #66.
Changes
errorfield.TrimStringsandConvertEmptyStringsToNullare both in the global middleware stack, so blank or padded reasons are already handled. The existing "records an optional reason" test covers this (it fails if those middlewares are disabled).The architecture wiki page mentions the new button and the refresh behavior.
Not included
Export formula escaping (raw data for the web view vs. escaped data for exports) is left for a separate change together with the other reports.
Testing