Repository navigation
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (9)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review. WalkthroughChannel-hidden and channel-visible events now use generated network event models for parsing and domain mapping. The conversion requires ChangesChannel Visibility Event Mapping
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to The visibility-event migration has no identified issue that should delay merging after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the event stream, Comment |
andremion
left a comment
There was a problem hiding this comment.
Looks good. One optional nit inline.
74f00d7 to
9def7f3
Compare
|



Goal
Parse the
channel.hiddenandchannel.visibleevents with the generated event models.Part of AND-1291
Implementation
ChannelHiddenEventandChannelVisibleEvent, and delete the hand-written DTOs.clear_history(hidden) andchannel(visible) are nullable in the vendored models: backends before v239.47.0 replay these events on/syncwithout them, and the spec marks them required. As before, a missingclear_historymaps to false and a missing channel to a channel with only its type and id. The model comments say when to drop the patch.Testing
GeneratedChannelEventParsingTestcovers both events from the socket and in the replayed shape, and rejects an event without a cid or user. The mapping tests cover every field, including both replayed shapes.On a device: hid a channel with and without clearing history and showed it again. Every domain field was set on the live events, and
/syncparsed the replayed events.🤖 Generated with Claude Code
Summary by CodeRabbit