Conversation
This algorithm follows the logic defined by the C++ standard, the mental model being that a result of an operation `a / b` is the same as if you did `cd /d a && cd /d b` in the Cmd shell (with an analog in the Unix shell).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #224.
This introduces
LocalPath::Kindproperty with all the possible Windows/Unix standard path kinds (except Windows' UNC and DOS Devices, so far).Also, this now adds proper handling of path kinds when combining paths and checking for
StartsWith/IsPrefix. Paths of different kinds interact as specified by the documentation; inspiration for the path combination was taken from the C++ standard.