Skip to content

ci(release): tomar la versión de FiscalApi.Cli.csproj - #5

Merged
mendozagit merged 1 commit into
mainfrom
fix/release-version-from-assembly
Oct 23, 2026
Merged

mendozagit merged 1 commit into
mainfrom
fix/release-version-from-assembly

Conversation

@mendozagit

@mendozagit mendozagit commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Resumen

El workflow de release pedía la versión en un input manual y la pasaba a `dotnet publish` con `-p:Version`. Ahora la versión sale del ensamblado: `` en `src/FiscalApi.Cli/FiscalApi.Cli.csproj`, la misma que reporta `fiscalapi --version`.

Cambios

  • Se quita el input `version` de `workflow_dispatch`.
  • El job `version` lee `` del csproj y falla si no es semántica.
  • Un tag `v<versión>` debe coincidir con ``; si no coincide, el job falla antes de compilar.
  • Ya no se sobrescribe la versión al publicar, ni en `release.yml` ni en `publish-linux.sh`. El smoke test sigue comparando `--version` con la versión del csproj.

Verificación

  • `dotnet run -- --version` con el build Release: `4.0.462`.
  • El paso `Resolve version` ejecutado con Git Bash: rama `main` da `4.0.462`; tag `v4.0.462` da `4.0.462`; tag `v4.0.463` falla con mensaje claro.
  • YAML válido y `publish-linux.sh` con `bash -n` limpio.
  • No se disparó el workflow de release: crearía un borrador con tag.

Summary by CodeRabbit

  • Release Management
    • Release versions are now taken from the project’s version setting. Release tags must match that version, helping ensure published builds and tags stay consistent.
    • Manual workflow runs no longer accept a version input; update the project version before starting a release.

El workflow de release pedía la versión en un input manual y la pasaba a
dotnet publish con -p:Version. Ahora la versión sale de <Version> en
src/FiscalApi.Cli/FiscalApi.Cli.csproj, que es la misma que el CLI reporta
en --version.

- Se quita el input "version" de workflow_dispatch.
- El job version lee <Version> del csproj y falla si no es semántica.
- Un tag v<versión> debe coincidir con <Version>; si no, el job falla.
- Ya no se sobrescribe la versión al publicar, en release.yml ni en
  publish-linux.sh. El paso de smoke test sigue comparando --version con
  la versión del csproj.
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b0380289-6a4d-4599-adf0-b65ccb0d85a3
📥 Commits

Reviewing files that changed from the base of the PR and between ca4f19b and 1c37a51.

📒 Files selected for processing: 2
  • .github/scripts/publish-linux.sh
  • .github/workflows/release.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The release workflow now reads the version from the CLI project file and validates release tags against it. Linux and non-Linux publish commands no longer override the project version.

Changes: Release versioning

Layer / File(s) Summary
Resolve and validate the project version
.github/workflows/release.yml
The workflow removes the dispatch version input, reads and validates the CLI project version, and requires tag names without a leading v to match it. The existing-tag error directs users to update the project version.
Publish without version overrides
.github/scripts/publish-linux.sh, .github/workflows/release.yml
The Linux and non-Linux publish commands no longer pass a version override. The Linux binary-version comparison remains unchanged.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 1c37a

The release version and published binary checks remain aligned. No merge-blocking issue was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: obtaining the release version from FiscalApi.Cli.csproj.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mendozagit
mendozagit merged commit 9a1c896 into main Oct 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant