Skip to content

Support development-scoped APM installs - #78

Closed
TyMick wants to merge 1 commit into
masterfrom
TyMick/apm-development-installs
Closed

TyMick wants to merge 1 commit into
masterfrom
TyMick/apm-development-installs

Conversation

@TyMick

@TyMick TyMick commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Note

Description written by Copilot on Ty’s behalf.

Daryl traced the failure after LogosBible/AgentConfiguration#69 switched shared-component setup to the full BSRUI bundle. BSRUI's root manifest also declares a production self-import, so fetching it makes APM resolve BSRUI -> BSRUI. The shared-component package itself has no BSRUI dependency. See his explanation, the consumer failure notice, and the failed run.

This PR adds opt-in dev: true, defaulting to false. It moves only configured root APM references out of production scope before calling install --dev. APM 0.14 otherwise leaves the old production declaration in place and gives it precedence. Unrelated imports stay unchanged.

migrate configured references to devDependencies
if update:
  apm update --yes
apm install --dev <packages>

The development path updates before installing and preserves the resulting lock changes. update: false skips the update. A synthetic self-cycle still blocks apm update --yes, so this does not replace the BSRUI producer fix. Remote snapshot refresh remains unproven; check the resolved manifest and lock during rollout.

The 14 APM convention tests and pinned APM 0.14 local-package migration passed. The full convention runner has one unrelated failure because .NET SDK 9.0.203 is unavailable.

Merge order

  1. Merge this writer support.
  2. Merge LogosBible/bible-study-react-ui#905 for the producer manifest and lock fix. It also removes the redundant individual-skill import that collided with the full bundle.
  3. Merge LogosBible/AgentConfiguration#72 to enable development installs.

BSRUI now passes ordinary APM 0.14 apm install from a fresh checkout using the standard shared cache. Its lock pins the corrected bundle by SHA with no branch ref; a separate empty-cache frozen install also fetched that SHA. A full cold-HOME install still hits a separate ~/.apm creation error while materializing AgentConfiguration's virtual packages.

After all three merge, rerun Apply Repo Conventions for affected repositories. The independent weekday sweep opens reviewable PRs and may run between merges. Wait for all three source changes before merging generated updates; a rerun alone does not prove stale snapshots changed.

@bgrainger

Copy link
Copy Markdown
Member

I'm confused; why don't we just remove https://github.com/LogosBible/bible-study-react-ui/blob/6a07ab0534a353dfc8da6cbdd87065fa9ff05058/apm.yml#L12 so bsr-ui doesn't depend on itself?

@TyMick

TyMick commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Sorry, didn’t realize this would ping code owners! Yeah I fixed the immediate problem in bible-study-react-ui#905, but the reason BSRUI depends on itself is because it’s part of the shared-component repo convention and also uses the shared-component convention (I didn’t realize the latter when changing the former).

I’ve paused repo-convention updates in BSRUI while we sort this out, but I think it’s worth keeping the shared-component convention there, because its skills are useful in BSRUI development. But there’s no reason we should be requiring LogosBible/bible-study-react-ui APM consumers to install everything we’ve installed there for development, hence the move from dependencies to devDependencies in apm.yml.

@TyMick

TyMick commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

I haven’t actually reviewed this PR yet, though, and I don’t think it’s quite the direction I’ll want to go. I should close it for now.

@TyMick TyMick closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants