Repository navigation
Conversation
… export functionality with workspace_id filtering
…e digest handling
…handling and streamline tag management
… adjust tagging for worker image
…splay success values correctly
…lizing centralized option label functions
… config coercion and improving option label normalization
… generic options type
…alization and strict equality checks
…ric option matching logic
…ation run summary to include failed trial errors
…g.version for improved version handling
… and update related processing logic to handle audio duration in various tasks
…ic for call import evaluations
…nd recording minutes billing
… and evaluations, enhancing API request handling
… call imports, enhancing audio file handling capabilities
… streamlining the API structure
…bulk operation handling in call imports
…new production origin and remove localhost references
[High impact] The changes since the previous review appear safe to merge, and the numbered finding is fixed.
|
Use the storage facade so S3, GCS, and Azure are selected via config instead of hard-coding s3_service in audio and staged CSV upload routes.
…n scatter_gather.py
…ling flush Invoke transcribe worker tests with explicit Celery self; resume sharded CSV materialization from max row_index; finalize FlexPrice partial batches on abort rollup; close idle platform discovery slices when import rows are terminal.
Collaborator
Author
1 similar comment
Collaborator
Author
…and improve handling of dollar-quoted strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed?
Imports scale (Linear imports epic) on branch
scaling-platform: backend and frontend changes so large CSV/platform imports, diarisation, and evaluations (100k+ rows) stay usable without timing out or melting Postgres/Redis/FlexPrice.call_imports/call_import_evaluationsroutes into modules; bulk cancel/retry/delete with server-side row filters (not huge UUID lists from the browser)._hand_off), eval allowed when rows are terminal even if discovery is still listing; stale slice reclaim + finalize when hydrate is idle; debounced rollup / batch status.pg_trgm+row_text_search(escapedILIKE) on conversation id + transcripts across eval rows and import filters.importPolling, bulk-op progress,any_evaluation_poll_activeon import detail/list).recording_duration_secondson rows (migrations 108/110).(This branch may include other work outside imports; the above is the imports-scale scope for this PR.)
Why?
Imports were hitting limits at tens/hundreds of thousands of rows: full-table scans for search and charts, discovery/import stuck in
processing, browser-driven bulk ops, upload timeouts, FlexPrice event storms, and insights/clusters loading every row pair. This PR keeps behavior backward-compatible while moving work to presign + worker paging + cache/sampling + indexes + safer billing.How to Test?
processingwhen rows idle.q; charts tab while running (cache stale → refresh on open)..venv/bin/pytest tests/test_workers/test_call_import_worker_modules.py tests/test_services/test_platform_call_imports.py tests/test_services/test_billing/test_flexprice_buffer.py tests/test_services/test_recording_minutes_batch_size.py tests/test_services/test_metric_aggregate_cache.py tests/test_api/test_call_import_evaluation_rows_search.py tests/test_workers/test_evaluate_call_import_row.py -k rollup_parent -qRelease Label
majorminor— backward-compatible imports-scale features and performancefixChecklist
CONTRIBUTING.mdguide.