Repository navigation
Center the 101 reader on a paper card; fix callouts in dark mode - #93
Merged
Merged
Conversation
Every 101 article (Scholarships 101, Application 101, ...) goes through ChecklistContentView, which sat flush left on the module's tinted background. It now centers in a 720px column on an elevated card, with padding that shrinks on narrow screens. Callouts had fixed light hex backgrounds, so in dark mode their light text sat on a light box and was nearly unreadable. They now tint from their own variant color, as their icon already did.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying timeline-prototype with
|
| Latest commit: |
0b04ffe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a878fa49.timeline-prototype.pages.dev |
| Branch Preview URL: | https://feature-reader-paper-card.timeline-prototype.pages.dev |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every 101 article (Scholarships 101, Application 101, and the rest) opens in the same reader,
ChecklistContentView. It sat flush left on the module's tinted background.clamp), down to 20px inside the card.Fix: callouts in dark mode
Callouts ("Surprising Stat", "Timing Matters", …) had fixed light hex backgrounds, so in dark mode their light text sat on a light box and was nearly unreadable. This was already broken before this change. They now tint from their own variant color, as their icon already did, and look about the same as before in light mode. The unused
bgfield is gone fromCALLOUT_VARIANT.Testing