Repository navigation
CandidateWindow: show the page number when candidates span pages - #6
Open
DaveTseng2019 wants to merge 1 commit into
Open
DaveTseng2019 wants to merge 1 commit into
DaveTseng2019 wants to merge 1 commit into
Conversation
DaveTseng2019
added a commit
to DaveTseng2019/PIME
that referenced
this pull request
Oct 17, 2026
- Point libIME2 at 68258fe: EasyIME/libIME2#6 merged with libIME2 master (6446eed). WHY: master moved libIME2 to 6446eed (EasyIME#4) while this branch pointed at 80fa4f7 (EasyIME#6). Neither contained the other, so the PR could not merge. Generated with assistance from Claude Code (Claude Opus 5.5). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The window only shows the current page of candidates, so users cannot tell that a character they look for is on a later page and think it is missing (e.g. 幣 is the 10th candidate of ㄅㄧˋ with 9 per page). Naming PgUp/PgDn also tells them how to get there. - Add setPageInfo(page, pageCount). When pageCount > 1, the window draws "PgUp page/pageCount PgDn" in grey at the bottom right. - recalculateSize() reserves one more line for it, and widens the window if the text is wider than the items. - Nothing changes when pageCount <= 1, the default. Architecture and design by Dave Tseng. Implementation generated with AI assistance from Claude Code (Claude Opus 5.5). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DaveTseng2019
force-pushed
the
feat/candidate-page-indicator
branch
from
October 30, 2026 05:18
68258fe to
f249c2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CandidateWindowonly shows the candidates of the current page. When a character is on a later page, nothing in the window says so, and users think it is missing (in PIME's 新酷音 with 9 per page, 幣 is the 10th candidate of ㄅㄧˋ, on page 2 of 17). Naming PgUp/PgDn also tells them how to get there.CandidateWindow::setPageInfo(page, pageCount)(page is 1-based).pageCount > 1, the window drawsPgUp page/pageCount PgDnin grey (COLOR_GRAYTEXT) at the bottom right.recalculateSize()reserves one more line for it, and widens the window if the text is wider than the items.pageCount <= 1(the default) nothing changes, so existing callers are not affected.The PIME side is EasyIME/PIME#927, which depends on this PR. The commit sits on
78e6104(the libIME2 commit PIME master uses) so #927 builds without other libIME2 changes; it merges into current master without conflicts.Testing: built x86/x64
PIMETextService.dll, installed on Windows 11 x64, and checked with 新酷音 that ㄅㄧˋ shows1/17, PageDown shows2/17, a one-page list shows no page line, and the text is not clipped. No new compiler warnings.Architecture and design by Dave Tseng. Implementation generated with AI assistance from Claude Code (Claude Opus 5.5).
🤖 Generated with Claude Code