perf: make require of large section-heavy developments fast - #1147
Merged
Merged
Conversation
bgregoir
approved these changes
Sep 22, 2026
strub
force-pushed
the
long-import
branch
3 times, most recently
from
September 23, 2026 13:08
e9289c9 to
2e39fb0
Compare
Loading a required file skips proofs, but three costs made it slow on big developments: - `EcEnv.Mod.by_mpath` on a parameterless module went through `EcSubst.subst_module` with an empty substitution, deep-copying the whole module expression on every lookup. Inside a section, the locality check performs this lookup for each module reference of each lemma and module, which dominated the loading time of files built on a large extracted module. `subst_module` now returns such modules unchanged. - The section dependency analysis descended into the declaration of every referenced operator and type, transitively, with a fresh cache per item. Each operator and type now records, when bound, the non-global items reachable through its declaration, and references replay that list instead of descending. Global items always satisfy the check, so the outcome is unchanged. - The docgen state appended each global item to a list with `@`, quadratic in the number of items of a theory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading a required file skips proofs, but three costs made it slow on
big developments:
EcEnv.Mod.by_mpathon a parameterless module went throughEcSubst.subst_modulewith an empty substitution, deep-copying thewhole module expression on every lookup. Inside a section, the
locality check performs this lookup for each module reference of each
lemma and module, which dominated the loading time of files built on
a large extracted module.
subst_modulenow returns such modulesunchanged.
The section dependency analysis descended into the declaration of
every referenced operator and type, transitively, with a fresh cache
per item. Each operator and type now records, when bound, the
non-global items reachable through its declaration, and references
replay that list instead of descending. Global items always satisfy
the check, so the outcome is unchanged.
The docgen state appended each global item to a list with
@,quadratic in the number of items of a theory.