Repository navigation
fix: complete root Stop continuation for Grok Build - #304
Merged
Merged
Conversation
Dimkox
marked this pull request as ready for review
November 3, 2026 09:29
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The compound-task continuation added in #303 did not cover Grok Build. The official Grok contract supports root Stop continuation, but its native lowercase event and end_turn reason need explicit handling. #303 was merged while this adapter correction was still being implemented.
Changes
end_turn.This completes the user's selected option 1. It reuses the original task/package and does not add a destination acceptance adapter. Current main changes are preserved.
Validation status
UNVERIFIED draft: final current-candidate reviews and qualifying gate are still running. Do not merge until this section records their exact head and required CI is green.
The Grok regression failed first. The earlier 28-test Stop/claim smoke passed at c4258d4, before integrating updated main; that is historical evidence. The new published candidate is 35db410, based on main 732b52c. No live Grok executable is available in this environment; native subprocess contract tests are not a live session qualification.
Related: #246, #252, #303. No broad issue is closed by this follow-up.