Skip to content

feat: add read-only deployment preflight (#300) - #302

Merged
Dimkox merged 1 commit into
mainfrom
feat/deploy-preflight-300-20261102
Nov 2, 2026
Merged

Dimkox merged 1 commit into
mainfrom
feat/deploy-preflight-300-20261102

Conversation

@Dimkox

@Dimkox Dimkox commented Nov 2, 2026

Copy link
Copy Markdown
Owner

Problem

A matching deployment script path or rebuilt snapshot checksum does not establish that the observed package is unchanged or that DEV delivery is ready. Operators need bounded local diagnostics that keep registration, provenance, recovery and execution separate.

Changes

  • Add getzilla deploy preflight --root PATH --manifest REL --json with a closed, bounded manifest and explicit root.
  • Admit public inputs before reads. Combine strict sensitive-file classes, the complete built-in secret-read exclusions and lexical policy/manifest selector exclusions. No selector, target or lock access.
  • Observe policy, manifest, operator and artifacts twice. Bind bytes, modes, file/root identities, schema/algorithm revision and a 300-second in-memory lifetime; recheck current inputs.
  • Emit a closed report with fixed diagnostics. Execution/grant flags remain false; provenance and recovery stay unverified; connection/delivery are not attempted.
  • Preserve flat release preparation, exact release-receipt approval behavior and legacy consumer selection decisions. Ship module/schema/guide through files and ZIP installation.

Verification status — UNVERIFIED draft

Published HEAD: f5c732eea389808aad13e6688f6ea7201d033299.
Tree: c2e9a3b7926307dd1a25d8041c535dc705c20690.
Comparison base: eea7af712c00855dac2bc727ff242f88bff2526f.

Author controls on the identical local tree: 67 tests and 279 subtests passed. Ruff and whitespace controls passed. Fresh exact-published-head smoke is running. Independent code, security, release and data reviews, full native PR verification and required exact-head Linux/Windows checks remain pending. These local controls are not merge authority.

An earlier candidate was blocked by independent security review: its ingestion classifier omitted known credential stores. A synthetic-only reproduction and failing regression were preserved. This candidate adds the full built-in exclusion floor before affected reads. No real credentials were accessed; the earlier failure is not reclassified as passing.

Limits and remaining scope

This is a local read-only observation, not a deploy executor or reusable capability. Windows reports MODE_UNSUPPORTED. It does not attest Git provenance or loaded code, evaluate custom secret_read_paths, recover shared locks or prove DEV delivery. Two passes do not provide a global atomic snapshot or hostile-writer isolation. No allowlist, snapshot pin, remote state, deployed policy or protection rule changes.

Refs #300 — keep open for the broader delivery/recovery requirements.
Jira: https://ii-tonya.atlassian.net/browse/GZDEV-55

Bind public inputs and registration without granting execution. Preserve flat release preparation and installed files/ZIP behavior. Include the reviewed before-open built-in credential exclusion repair.

Refs #300. Source transport only; fresh exact-head qualification remains required.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T19:51:54.062191Z f5c732e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant