Repository navigation
feat: add read-only deployment preflight (#300) - #302
Merged
Merged
Conversation
Bind public inputs and registration without granting execution. Preserve flat release preparation and installed files/ZIP behavior. Include the reviewed before-open built-in credential exclusion repair. Refs #300. Source transport only; fresh exact-head qualification remains required.
This was referenced Nov 2, 2026
Dimkox
marked this pull request as ready for review
November 2, 2026 19:50
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A matching deployment script path or rebuilt snapshot checksum does not establish that the observed package is unchanged or that DEV delivery is ready. Operators need bounded local diagnostics that keep registration, provenance, recovery and execution separate.
Changes
getzilla deploy preflight --root PATH --manifest REL --jsonwith a closed, bounded manifest and explicit root.Verification status — UNVERIFIED draft
Published HEAD:
f5c732eea389808aad13e6688f6ea7201d033299.Tree:
c2e9a3b7926307dd1a25d8041c535dc705c20690.Comparison base:
eea7af712c00855dac2bc727ff242f88bff2526f.Author controls on the identical local tree: 67 tests and 279 subtests passed. Ruff and whitespace controls passed. Fresh exact-published-head smoke is running. Independent code, security, release and data reviews, full native PR verification and required exact-head Linux/Windows checks remain pending. These local controls are not merge authority.
An earlier candidate was blocked by independent security review: its ingestion classifier omitted known credential stores. A synthetic-only reproduction and failing regression were preserved. This candidate adds the full built-in exclusion floor before affected reads. No real credentials were accessed; the earlier failure is not reclassified as passing.
Limits and remaining scope
This is a local read-only observation, not a deploy executor or reusable capability. Windows reports MODE_UNSUPPORTED. It does not attest Git provenance or loaded code, evaluate custom secret_read_paths, recover shared locks or prove DEV delivery. Two passes do not provide a global atomic snapshot or hostile-writer isolation. No allowlist, snapshot pin, remote state, deployed policy or protection rule changes.
Refs #300 — keep open for the broader delivery/recovery requirements.
Jira: https://ii-tonya.atlassian.net/browse/GZDEV-55