Repository navigation
feat: add non-authorizing offline admission preview - #298
Merged
Merged
Conversation
Bind exact request and account metadata for review, preserving live dispatch refusal. Reject malformed account and preview fields before copying. Related to #235. UNVERIFIED transport; qualification and required exact-head checks are separate.
This was referenced Nov 2, 2026
Open
Dimkox
marked this pull request as ready for review
November 2, 2026 11:34
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Issue #235 needs an exact-request admission boundary before any account rotation or provider continuation can be enabled. The retained preview slice also copied unvalidated account/preview values, allowing structured data and string subclasses to invoke copy hooks or escape the intended fixed errors.
Changes
ready_for_reviewwith bothdispatch_permitted=falseandaccount_identity_verified=false.The preview checksum is unkeyed and reproducible; it is not authentication, provenance or account authority. The root observation is point-in-time, not a workspace lock. Existing
openai_model_request.dispatchstill unconditionally refuses withdata_admission_unavailablebefore claims or network. No live adapter is qualified by this delivery.Qualified source
a1eb5fa01fb27f1e88fbf9d8aedcfaf47a3b78868b99b3027e44d3972c4287b32c00193a854a5f36d6c2c109991ca4f9fc7b6924ef5b7dab08ac204e5b78538ea56a23d0e042ef124e115fe6f3aae756b38fcaf0d622b8e508a3bd2eaf104b6f8a941b0e1796cf25b040f6b642a969964a8eb1c0e642e26f8ca2b2e1Verification
Preserved failed attempts and limits
The first full attempt stopped before tests because the cost detector classified the endpoint string in a
self.assertEqualas a paid call. This false positive remains tracked in issue #220. The separate runtime contract records enforced zero live calls/spend; the positive v1 schema minima are conservative upper bounds only, not live permission. Its actual enforcement symbol is the tested, unconditionally refusingdispatch. The added contract invalidated the old scope record, which was rebound through the native API using the existing owner consent. No paid-run approval was created.The second attempt stopped because the local invocation omitted online OSV configuration. Both actual FAIL reports are retained. The final run enabled OSV and independently passed; no detector, test, threshold or guard was weakened to obtain it.
Tracking and recovery
This is a source prerequisite for #235 / GZDEV-39; the broader six-client rotator remains open. It does not publish a version or activate a provider.
If a fixed-error escape, accepted changed/expired preview or any grant/journal/network effect appears, hold delivery and repair the isolated branch, or use a reviewed forward-fix/revert PR after merge. Keep dispatch unavailable and repeat fresh source-bound reviews and gates. Reviewer scratch cleanup observations remain the separate existing issue #297.