Repository navigation
feat(frontend): name the wallet a request is waiting for - #65
Merged
Merged
Conversation
A wallet prompt does not always come to the front: an extension can sit behind a small number on its toolbar icon, and a paired wallet is another device. The app now shows <qrl-approval-hint> from @qrlwallet/connect-ui 0.6.0 at the top right when a wallet request has been open for 2.5 seconds without an answer, with the wallet's own icon and name. It only informs and never opens or raises anything. - poolStore counts its wallet requests where they are sent (createApprovalRequests): the extension's and the relay's account request and the transaction request. The count is forgotten when the wallet state is reset. - `approvalWallet` names the wallet: the announcement of the extension a connection request went to, or MyQRLWallet on a paired device for the relay. - @qrlwallet/connect-ui 0.3.0 to 0.6.0. Checked in headless Chromium on a configured local build with a stand-in extension wallet that never answers the connection request: no hint at 1.5 s, "Waiting for <wallet>" at 4 s.
- The relay's wallet (MyQRLWallet on a paired device) is named as soon as a relay connection begins or a stored session is resumed, so its account request no longer shows as an unnamed extension. It is one shared object. - A new relay or extension connection restarts the count: a request still open in the wallet before no longer shows under the new wallet's name. - The subscription to the count is stable across renders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A wallet prompt does not always come to the front: an extension can sit behind a small number on its toolbar icon, and a paired wallet is another device. The app now shows
<qrl-approval-hint>from@qrlwallet/connect-ui0.6.0 at the top right when a wallet request has been open for 2.5 seconds without an answer, with the wallet's own icon and name. It only informs and never opens or raises anything.Changes
poolStorecounts its wallet requests where they are sent (createApprovalRequests): the extension's and the relay's account request and the transaction request. The count is forgotten when the wallet state is reset.approvalWalletnames the wallet: the announcement of the extension a connection request went to, or MyQRLWallet on a paired device for the relay.ApprovalHint: the same thin React wrapper QuantaSwap uses; one instance inApp.@qrlwallet/connect-ui0.3.0 to 0.6.0.Checks
Note: the live site runs the unconfigured native build, where Connect is disabled, so the hint has nothing to show there until a pool is deployed.