Skip to content

feat(frontend): name the wallet a request is waiting for - #65

Merged
moscowchill merged 2 commits into
devfrom
feat/approval-hint
Nov 16, 2026
Merged

moscowchill merged 2 commits into
devfrom
feat/approval-hint

Conversation

@moscowchill

Copy link
Copy Markdown
Contributor

A wallet prompt does not always come to the front: an extension can sit behind a small number on its toolbar icon, and a paired wallet is another device. The app now shows <qrl-approval-hint> from @qrlwallet/connect-ui 0.6.0 at the top right when a wallet request has been open for 2.5 seconds without an answer, with the wallet's own icon and name. It only informs and never opens or raises anything.

Changes

  • poolStore counts its wallet requests where they are sent (createApprovalRequests): the extension's and the relay's account request and the transaction request. The count is forgotten when the wallet state is reset.
  • approvalWallet names the wallet: the announcement of the extension a connection request went to, or MyQRLWallet on a paired device for the relay.
  • ApprovalHint: the same thin React wrapper QuantaSwap uses; one instance in App.
  • @qrlwallet/connect-ui 0.3.0 to 0.6.0.

Checks

  • lint (with format:check), typecheck, 81 tests and build pass.
  • Headless Chromium on a configured local build with a stand-in extension wallet that never answers the connection request: no hint at 1.5 s, "Waiting for " at 4 s.

Note: the live site runs the unconfigured native build, where Connect is disabled, so the hint has nothing to show there until a pool is deployed.

A wallet prompt does not always come to the front: an extension can sit
behind a small number on its toolbar icon, and a paired wallet is another
device. The app now shows <qrl-approval-hint> from @qrlwallet/connect-ui
0.6.0 at the top right when a wallet request has been open for 2.5
seconds without an answer, with the wallet's own icon and name. It only
informs and never opens or raises anything.

- poolStore counts its wallet requests where they are sent
  (createApprovalRequests): the extension's and the relay's account
  request and the transaction request. The count is forgotten when the
  wallet state is reset.
- `approvalWallet` names the wallet: the announcement of the extension a
  connection request went to, or MyQRLWallet on a paired device for the
  relay.
- @qrlwallet/connect-ui 0.3.0 to 0.6.0.

Checked in headless Chromium on a configured local build with a stand-in
extension wallet that never answers the connection request: no hint at
1.5 s, "Waiting for <wallet>" at 4 s.
- The relay's wallet (MyQRLWallet on a paired device) is named as soon as a
  relay connection begins or a stored session is resumed, so its account
  request no longer shows as an unnamed extension. It is one shared object.
- A new relay or extension connection restarts the count: a request still
  open in the wallet before no longer shows under the new wallet's name.
- The subscription to the count is stable across renders.
@moscowchill
moscowchill merged commit 54f57ae into dev Nov 16, 2026
1 check passed
@moscowchill
moscowchill deleted the feat/approval-hint branch November 16, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant