Repository navigation
Conversation
…s layer Issue 138: MSFS 2024 crashed re-entering VR on Virtual Desktop. 0.20.1 stamps the runtime's clock just before xrCreateSession (dab7806), through xrConvertWin32PerformanceCounterToTimeKHR taken at the previous session. That pointer outlived its instance; after xrDestroyInstance the runtime's DLL is unloaded, so the next xrCreateSession called into unmapped code (the crash dump's faulting call is that clock call in the signed 0.20.1 DLL). Every function taken from the runtime's instance now goes with it (the clock, xrGetInstanceProperties, xrGetVisibilityMaskKHR, xrPathToString, xrGetCurrentInteractionProfile and the chain's xrGetInstanceProcAddr), and the clock is taken again for each instance. DLSS 5 mods: a layer above VectorXR that asks for a function before any instance exists (Cheeky Foveated DLSS's layer probes xrEnumerateInstanceExtensionProperties that way) made VectorXR call through an empty pointer, so the game crashed at startup whenever such a layer was above it. It now gets XR_ERROR_HANDLE_INVALID, which such probes treat as unknown. The log names Cheeky Foveated DLSS's OpenXR layer above or below VectorXR, and its in-game modules. Above, it takes the application's quad-view request for its own quad views, and the Quadviews INACTIVE line now says so instead of pointing at the game's setting. Test: layer_load. A function asked for before any instance, and after the last instance is destroyed, is refused with no call below; an instance above Cheeky's layer logs it. The framegen presenter timing tests (pacing, ceiling, policy_late) failed on this run with Star Citizen holding the CPU at 100%; unrelated to this change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The clock conversion was also taken at instance creation, which gave an instance's first xrCreateSession a runtime clock stamp it did not have in 0.20.1, and with it the clock-based stale-event check instead of the first-IDLE fallback. Only the clearing is needed for issue 138; the clock is again taken at the session's Turbo setup, so first sessions behave exactly as in 0.20.1. Test: layer_load, eye_gaze, turbo_frame, turbo_trace, turbo_recovery. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ports the in-app guides and walkthroughs from the forward branch for what 0.20 already ships: the start guide, anti-cheat, Quadviews, Turbo, Frame Generation, Pivot, Depth and the On-Screen Display. The Performance Crop, Sharpening & Color and Screenshots guides stay behind until those features ship. Each enhancement's page links to its guide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
community.json gains a patreon entry (enabled, url, optional message, one string or one per language). The button shows on Home and About only while it is enabled with an HTTPS patreon.com page; a missing entry, a failed request or anything invalid hides it. The published entry starts disabled. A community.override.json beside settings.json replaces the published config's fields, so a build can preview the promotion before it is published. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On Home the promotion is a third titled column beside Discord and Ko-fi, with every column's button aligned along the bottom. On About its button matches Ko-fi's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…l badges A guide opened by an enhancement page's "Read the guide" link now leads with "Back to <page>", with All guides on the right. Opened from the Guides page, it keeps All guides and Open <page>. Quadviews and Frame Generation no longer carry an Experimental badge in the guides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Leaving the Guides page closes the open guide, so the sidebar's Guides always shows the list. A "Read the guide" link still opens its guide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Michael · project thread
VectorXR 0.20.2: a fix release for 0.20.1 with an in-app Guides page. Supersedes #139.
Changes
XR_ERROR_HANDLE_INVALIDinstead of a call through an empty pointer. The log names Cheeky's layer and its position.community.jsongains apatreonentry (enabled,url, optionalmessage). Home and About show a Patreon button beside Ko-fi only while it is enabled with an https patreon.com page; a missing entry or failed fetch hides it. A localcommunity.override.jsonpreviews it. Seedocs/community-config.md.release/notes/v0.20.2.md).Testing
vue-tsc,cargo check; Guides navigation and the Patreon button checked in a headless browser with and without the config.🤖 Generated with Claude Code