Repository navigation
Add parameterized cube primitive benchmarks - #789
Merged
Yuan-Xinyi merged 3 commits intoOct 17, 2026
Merged
Yuan-Xinyi merged 3 commits into
Yuan-Xinyi merged 3 commits into
Conversation
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryAdds five cube-size variants for six skills, with separate nominal populations across four tracks.
Reviews (2) · Last reviewed commit: "refactor(benchmark): parameterize cube p..." · Reviewed by Greptile |
Yuan-Xinyi
merged commit Oct 17, 2026
e011cf6
into
codex/composed-spatial-generalization
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
codex/composed-spatial-generalizationDescription
Adds the first-stage primitive-geometry generalization populations to the YAML-configured Atomic Skill benchmark.
The benchmark uses EmbodiChain's built-in
cubeprimitive and exposes geometry through the existingobjects[].sizeparameter. Each size is defined once as a YAML anchor; the runtime object override and the domain provenance reference the same value. A new primitive variation therefore has one parameter edit surface, while the resolved suite and every case manifest retain the exact object configuration.nominalcubesize[0.05, 0.05, 0.05]cube_uniform_40mmcubesize[0.04, 0.04, 0.04]cube_uniform_60mmcubesize[0.06, 0.06, 0.06]cube_aspect_xcubesize[0.07, 0.042258, 0.042258]cube_aspect_ycubesize[0.042258, 0.07, 0.042258]cube_aspect_zcubesize[0.042258, 0.042258, 0.07]primitive-cube-rigid-objectPickUp,Pour,AxisAlignprimitive-cube-held-pose-targetMoveHeldObjectprimitive-cube-place-targetPlaceprimitive-cube-position-targetPushObjectThe stage is deliberately expressed through basic primitive parameters. Additional registered primitives and mesh-backed geometries can reuse the same domain structure in later stages. Primitive populations have independent track groups, so their summaries stay separate from position, orientation, workspace-shell, and composed-pose summaries.
This PR adds benchmark definitions and validation only; no benchmark results were run or committed.
Type of change
Screenshots
Not applicable.
Validation
black .withblack==26.3.1black --check --diff --color .— 5408 files unchangedpython docs/scripts/check_api_docs.py— 2613/2613 exports documentedpython -m pytest -q -p no:cacheprovider -c /dev/null --noconftest tests/benchmark/motion_generation/test_contracts.py tests/benchmark/motion_generation/test_generalization.py— 27 passedpython -m py_compile tests/benchmark/motion_generation/test_atomic_pose_config.pytest_atomic_pose_config.pycollection is unavailable in the current local environment because optionalopen3dis not installedChecklist
black .command to format the code base.