Skip to content

The console check waits for dwl's input devices before it asks for Alt+p - #609

Merged
DevomB merged 1 commit into
proof-compositor-stackfrom
gui-vt-keys-after-resume
Oct 16, 2026
Merged

DevomB merged 1 commit into
proof-compositor-stackfrom
gui-vt-keys-after-resume

Conversation

@DevomB

@DevomB DevomB commented Oct 16, 2026

Copy link
Copy Markdown
Owner

The compositor proof's run failed one guest check, vt-desktop-takes-keys: "menu windows: 1 before Alt+p, 1 after".

After Ctrl+Alt+F1, seatd enables dwl's seat again. dwl answers clients at once, which is what vt-desktop-back waits for. libinput reopens the input devices through the seat a moment later. The guest printed GT KEY-MENU-AFTER-VT as soon as dwl answered, and the host pressed Alt+p once, so a press that arrived before the devices were back was lost.

The check now:

  • counts the /dev/input/event descriptors dwl holds before the switch;
  • waits up to 15 s after the switch back until dwl holds as many again, then asks for the key;
  • says so in an INFO line if they do not come back;
  • names both counts in its failure message if no menu opens.

A desktop that loses its keyboard for good after a console switch still fails the check, now with the reason in its message.

Base: #585's branch, since the check's surroundings are its. It merges into #585's head for the re-proof, and into #600.

Back from tty2, dwl answers clients as soon as its seat is enabled again, and libinput reopens the keyboards through the seat a moment later. The single Alt+p the host sends on GT KEY-MENU-AFTER-VT could arrive in between and be lost, as in the compositor proof's run (menu windows: 1 before Alt+p, 1 after). The check now waits until dwl holds as many /dev/input/event descriptors as before the switch, says so when they do not come back, and names both counts if no menu opens.
@DevomB
DevomB merged commit 9ffce1d into proof-compositor-stack Oct 16, 2026
7 of 8 checks passed
DevomB added a commit that referenced this pull request Oct 16, 2026
DevomB added a commit that referenced this pull request Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant