Repository navigation
The console check waits for dwl's input devices before it asks for Alt+p - #609
Merged
Merged
Conversation
Back from tty2, dwl answers clients as soon as its seat is enabled again, and libinput reopens the keyboards through the seat a moment later. The single Alt+p the host sends on GT KEY-MENU-AFTER-VT could arrive in between and be lost, as in the compositor proof's run (menu windows: 1 before Alt+p, 1 after). The check now waits until dwl holds as many /dev/input/event descriptors as before the switch, says so when they do not come back, and names both counts if no menu opens.
DevomB
added a commit
that referenced
this pull request
Oct 16, 2026
DevomB
added a commit
that referenced
this pull request
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compositor proof's run failed one guest check,
vt-desktop-takes-keys: "menu windows: 1 before Alt+p, 1 after".After Ctrl+Alt+F1, seatd enables dwl's seat again. dwl answers clients at once, which is what
vt-desktop-backwaits for. libinput reopens the input devices through the seat a moment later. The guest printedGT KEY-MENU-AFTER-VTas soon as dwl answered, and the host pressed Alt+p once, so a press that arrived before the devices were back was lost.The check now:
/dev/input/eventdescriptors dwl holds before the switch;A desktop that loses its keyboard for good after a console switch still fails the check, now with the reason in its message.
Base: #585's branch, since the check's surroundings are its. It merges into #585's head for the re-proof, and into #600.