Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minify_string only treats a backslash as the start of an escape when the next byte is a double quote, so a string value that ends in an escaped backslash (for example the value "\") is misread: the second backslash and the real closing quote are taken as an escaped quote and consumed, and the scanner keeps going past the end of the string. Everything after it, including comments and whitespace that minify is meant to strip, is then copied verbatim until the next quote. For input like {"p":"\" /* c */ , "q":1} the minified output keeps the comment and no longer parses.
Treat any non-NUL byte after a backslash as an escaped character so the pair is copied and skipped together. Added a regression test in tests/minify_tests.c covering an escaped backslash right before the closing quote.