Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
BUILD_SHARED_AND_STATIC_LIBS=ON, only the sharedcjsontarget links tom. The siblingcjson-statictarget therefore loses the math dependency, including throughcjson_utils-staticand the installed CMake exports.Link the static target to
munder the existing non-Windows condition. Add a dual-build static-link test and run it in the Linux GCC/Clang CI jobs with-fno-builtin-fabs, so compiler builtins cannot hide the missing dependency.Verified locally with GCC 14.2 and CMake 3.31.6: the new test and installed static consumers fail on the original code with undefined references to
fabs, then pass with this change. Shared-only, static-only, dual-build, utils on/off, and ordinary compiler-flag controls pass. The full dual-build suite passes all 23 tests. Clang, Windows, macOS, the minimum CMake 3.5 version, and hosted CI were not run locally.