Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
Both scrubbers skip binary data without a copy. The field name, redacted output, and reader state stay correct.
🤖 Datadog Autotest · Commit 1665229 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
What Does This Do
Both BSON scrubbers currently read binary payloads into memory before replacing them with
"?"in the span resource name. UseBsonReader.skipValue()instead, preserving the field name and redacted output while avoiding the payload allocation and copy.Benchmark results
Standalone JMH benchmark using the full before/after
BsonScrubber34implementations andBsonBinaryReader, with pre-encoded inputs and identical output verification:JMH 1.37, Temurin 17.0.18, Apple M4 Max, BSON 3.4.0; three forks, two 1-second warmups, three 1-second measurements, one thread, 512 MiB heap, and GC profiling. Input encoding is excluded. The 4 KiB timing confidence intervals overlap; its allocation reduction is clear.
Benchmark sources and results remain outside the PR.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]