Repository navigation
Merge Codex hooks.json and tolerate tool-installed skill dirs - #25
Merged
Merged
Conversation
Owner
Author
Adversarial Review: PR #25 (Codex hooks merge, tool-installed skill dirs, Zed theme)Evidence: ran CRITICAL
HIGH
MEDIUM
LOW
Cross-Persona Overlaps
Verdict: CONCERNS -> addressed in 74aeff2Checks
Not verified
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.codex/hooks.jsonbecomes amodify_merge (same recipe as~/.claude/settings.jsonand Zed):PreToolUse/SessionStartstay managed, events other tools install (npx impeccable installwritesPostToolUseandStop) survivechezmoi applyrun_after_sync-skills.sh.tmplno longer exits 1 when a real directory sits in~/.agents/skills/after the one-time legacy migration; tool-installed skills (impeccable) stay in place and are mirrored to~/.claude/skills/. The script had been failing on this machine since 2026-10-04 for that reason, so new upstream skills were not being linkedthemematches the object Zed's picker writes (mode: system, lightOne Light, darkSynthwave84 Soft), ending theMMdrift onsettings.jsonWARNINGon stderr (it still wins)Checks
make lintpassmake codex-checkpass (new cases: merge keeps managedPreToolUseauthoritative and keeps a foreignPostToolUse; sync script keeps a real dir, links new upstream skills beside it, mirrors it to Claude without churn, warns when it shadows a source skill)make test: only[Config] chezmoi verifyfails, identically onmain-- it runs against the live source (~/.local/share/chezmoi, still pre-PR) whose renderedhooks.json, Zedsettings.json, and~/CODE/CLAUDE.mddiffer from the live home. That is exactly the drift this PR removes; expected to pass after merge + applychezmoi --source ./home difffor~/.codex/hooks.json,~/.config/zed/settings.json,~/.agents/skills,~/.claude/skills: empty against the live homeManual testing
chezmoi applyon the live source after merge; confirm~/.codex/hooks.jsonkeeps the impeccable events and Codex does not re-prompt for trust (source onmainhashes hooks individually by event/matcher/command, so a reformat should not re-prompt)