Fix late instantiated virtual methods - #411
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#394 translates records that contain declared but not defined methods. That did not cover virtual methods in derived records. This PR solves that.
cpp2rust generated an empty
impl Base for Derived {}when no virtual method had a definition. Then, when an out-of-line definition was encountered, cpp2rust refused it because multipleimpl Base for Derived {}are not allowed by rustc. This resulted in usages of undefiend methods because neither the record visitor nor the out-of-line method visitor generated the methods.The fix is to defer the
impl Base for Derived {}block at the end of the file, similar to how methods on Ptr are deferred. At the end of the file, where every TU was visited, we know all the methods that have definitions.