Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102.
PageText trimmed trailing sentence punctuation once, before removing unmatched closing brackets. When a source URL sat at the end of a parenthetical sentence, the bracket removal exposed punctuation that then became part of the link destination: "(See https://example.com/pricing.)" linked to "https://example.com/pricing." instead of "https://example.com/pricing".
The trim/strip now repeats until the suffix is stable, so punctuation hidden behind an unmatched closer is dropped on the next pass. Balanced parentheses inside a URL (e.g. wiki links) are still preserved, and the visible paragraph text is unchanged — only the href changes.
Test: added "source links drop punctuation left behind by an unmatched closing bracket" to openbot/app/tests/pages.test.tsx, covering the two reported cases plus a balanced-parens URL with a trailing period. Verified the new test fails on pristine code (hrefs came back with the trailing "." and ",") and passes with the fix. Full pages.test.tsx: 47/47 pass. App typecheck and biome format/lint clean.