Repository navigation
fix: answer 404 for a conversation, call or Dot that does not exist - #98
Open
charan-rathore wants to merge 1 commit into
Open
charan-rathore wants to merge 1 commit into
charan-rathore wants to merge 1 commit into
Conversation
Signed-off-by: Charan Rathore <180254320+charan-rathore@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the workspace routes, asking for a conversation, call or Dot that does not exist answers
503with "The service request failed. Check the server configuration and try again." Examples:GET /api/conversations/<unknown>/captureandGET /api/voice/calls/<unknown>. A missing resource is a caller error, so the status and message send the user to check the server configuration for something that is not wrong with the server.Change
onErrorhandler inworkspaceRoutesnow answers404with the error's own message for "Dot not found", "Call not found" and "Conversation does not belong ..." instead of503.503, unchanged.tests/page-routes.test.tsfor the conversation capture and call routes.Testing
typecheck, eslint, prettier check and the full vitest suite (234 tests) pass. The new test fails without the change to
workspace-routes.tsand passes with it.