Skip to content

fix(test-cli): run tests through test_core's main — v3.1.5 - #58

Merged
gmpassos merged 3 commits into
masterfrom
fix/test-core-0.6.21-executable
Oct 9, 2026
Merged

gmpassos merged 3 commits into
masterfrom
fix/test-core-0.6.21-executable

Conversation

@gmpassos

@gmpassos gmpassos commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

test_core 0.6.21 removed runTests() and completeShutdown() from package:test_core/src/executable.dart. BonesUITestCLI called both of them, so a fresh dart pub global activate bones_ui (which resolves test_core 0.6.21) now fails to build the CLI:

lib/src/bones_ui_test_cli.dart:355:27: Error: Method not found: 'runTests'.
lib/src/bones_ui_test_cli.dart:356:21: Error: Method not found: 'completeShutdown'.
  • The CLI now calls test_executable.main(testArgs) instead.

    • In 0.6.21, main runs the tests, releases the signal and stdin listeners, and returns without calling exit. So _processJsonReportFile() still runs after it.
    • In 0.6.20, main was exactly runTests followed by completeShutdown, so the change also works with the previous version.
  • Version 3.1.5, with a CHANGELOG entry (3.1.4 is already tagged).

  • CI (.github/workflows/dart.yml):

    • actions/checkout@v6 and codecov/codecov-action@v5 run on Node 24, which removes the Node 20 deprecation warning. Codecov now gets its token through the token input.
    • A concurrency group cancels a branch's running jobs when a new push arrives.
    • Read-only permissions and per-job timeout-minutes.
    • The dart pub get right before dart pub upgrade is dropped, since upgrade already resolves.

Tests

  • dart analyze lib bin: no issues, with test_core 0.6.20 and with 0.6.21.
  • Ran a real bones_ui test suite of an app (101 browser UI tests, headless Chrome) through this branch's CLI with test_core 0.6.21: all passed, and the CLI completed normally.

Publishing 3.1.5 fixes downstream CI jobs that run dart pub global activate bones_ui.

🤖 Generated with Claude Code

gmpassos and others added 3 commits October 8, 2026 21:04
test_core 0.6.21 removed the runTests/completeShutdown pair from its
executable, so `dart pub global activate bones_ui` failed to build the
CLI (Method not found: 'runTests'). `main` runs the tests, releases
the signal and stdin listeners and returns without exiting, on 0.6.20
too, so the JSON report is still processed after it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
actions/checkout@v5 and codecov/codecov-action@v5 (Node 24: no Node 20
deprecation warning; codecov token via its `token` input); a
concurrency group cancels a branch's running jobs on a new push;
read-only permissions; job timeouts; drops the `dart pub get` right
before `dart pub upgrade`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.89%. Comparing base (a0a25b0) to head (6a0c009).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   93.26%   92.89%   -0.37%     
==========================================
  Files          34       34              
  Lines       10342     9420     -922     
==========================================
- Hits         9645     8751     -894     
+ Misses        697      669      -28     
Flag Coverage Δ
unittests 92.89% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmpassos
gmpassos merged commit 5629f1c into master Oct 9, 2026
4 of 5 checks passed
@gmpassos
gmpassos deleted the fix/test-core-0.6.21-executable branch October 9, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant