Repository navigation
fix(test-cli): run tests through test_core's main — v3.1.5 - #58
Merged
Merged
Conversation
test_core 0.6.21 removed the runTests/completeShutdown pair from its executable, so `dart pub global activate bones_ui` failed to build the CLI (Method not found: 'runTests'). `main` runs the tests, releases the signal and stdin listeners and returns without exiting, on 0.6.20 too, so the JSON report is still processed after it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
actions/checkout@v5 and codecov/codecov-action@v5 (Node 24: no Node 20 deprecation warning; codecov token via its `token` input); a concurrency group cancels a branch's running jobs on a new push; read-only permissions; job timeouts; drops the `dart pub get` right before `dart pub upgrade`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 93.26% 92.89% -0.37%
==========================================
Files 34 34
Lines 10342 9420 -922
==========================================
- Hits 9645 8751 -894
+ Misses 697 669 -28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_core0.6.21 removedrunTests()andcompleteShutdown()frompackage:test_core/src/executable.dart.BonesUITestCLIcalled both of them, so a freshdart pub global activate bones_ui(which resolvestest_core0.6.21) now fails to build the CLI:The CLI now calls
test_executable.main(testArgs)instead.mainruns the tests, releases the signal and stdin listeners, and returns without callingexit. So_processJsonReportFile()still runs after it.mainwas exactlyrunTestsfollowed bycompleteShutdown, so the change also works with the previous version.Version 3.1.5, with a CHANGELOG entry (3.1.4 is already tagged).
CI (
.github/workflows/dart.yml):actions/checkout@v6andcodecov/codecov-action@v5run on Node 24, which removes the Node 20 deprecation warning. Codecov now gets its token through thetokeninput.concurrencygroup cancels a branch's running jobs when a new push arrives.permissionsand per-jobtimeout-minutes.dart pub getright beforedart pub upgradeis dropped, sinceupgradealready resolves.Tests
dart analyze lib bin: no issues, withtest_core0.6.20 and with 0.6.21.bones_ui testsuite of an app (101 browser UI tests, headless Chrome) through this branch's CLI withtest_core0.6.21: all passed, and the CLI completed normally.Publishing 3.1.5 fixes downstream CI jobs that run
dart pub global activate bones_ui.🤖 Generated with Claude Code