Skip to content

v1.27.2: APICronStoreDB.buildRepositories returns List<DBSQLEntityRepository> - #191

Merged
gmpassos merged 1 commit into
masterfrom
fix/cron-store-repositories-type
Oct 18, 2026
Merged

gmpassos merged 1 commit into
masterfrom
fix/cron-store-repositories-type

Conversation

@gmpassos

Copy link
Copy Markdown
Contributor

Summary

  • APICronStoreDB.buildRepositories now returns List<DBSQLEntityRepository> instead of List<EntityRepository<Object>>.
    • The result can be added to a provider's list of DBSQLEntityRepository with no cast; before, it needed .cast<DBSQLEntityRepository>().
    • It still fits a list of EntityRepository, because lists are covariant.
    • Any repository can still be added to the returned list. With a narrower element type, for example <Entity>, adding a non-Entity repository would throw a TypeError at runtime.
  • Version 1.27.2 + CHANGELOG.

Tests

  • A compile-time check that buildRepositories fits both kinds of provider list.
  • The DB test provider keeps the repositories as List<DBSQLEntityRepository>, and a new test checks their tables and entity types.
  • Unit suite: 2156 pass; cron DB tests on PostgreSQL and MySQL: 18 pass; dart analyze --fatal-infos: no issues.

🤖 Generated with Claude Code

…ository>

It can be added to a provider's list of DBSQLEntityRepository with no
cast, and still to a list of EntityRepository (lists are covariant).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.53%. Comparing base (d853d95) to head (a7bd4e3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files          73       73           
  Lines       25179    25179           
=======================================
+ Hits        24054    24055    +1     
+ Misses       1125     1124    -1     
Flag Coverage Δ
unittests 95.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmpassos
gmpassos merged commit ed9e707 into master Oct 18, 2026
11 checks passed
@gmpassos
gmpassos deleted the fix/cron-store-repositories-type branch October 18, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant