fix: resolve linked resources against the plain file's directory - #315
Merged
NejcS merged 1 commit intoSep 28, 2026
Merged
Conversation
NejcS
force-pushed
the
fix/eng-205-resolve-linked-resources-against-spec-dir
branch
from
September 16, 2026 11:09
5e4cb5b to
03dede9
Compare
NejcS
changed the title
bananaplain
reviewed
Sep 21, 2026
bananaplain
approved these changes
Sep 21, 2026
bananaplain
left a comment
bananaplain
left a comment
Contributor
There was a problem hiding this comment.
Plain forge rules should be synced too: in rules/linked-resources.md, section "File location and path resolution": the first bullet still says paths resolve against the directory where codeplain is run.
NejcS
force-pushed
the
fix/eng-205-resolve-linked-resources-against-spec-dir
branch
from
September 21, 2026 13:36
9dddf4c to
c166fb3
Compare
Contributor
Author
|
Thanks, @bananaplain I improved that. I also opened a PR in plain-forge to fix the references: plainlang/plain-forge#25 |
NejcS
force-pushed
the
fix/eng-205-resolve-linked-resources-against-spec-dir
branch
from
September 25, 2026 07:36
c166fb3 to
886de4b
Compare
Contributor
|
Something seems to be up with the tests @NejcS 👀 |
Contributor
Author
NejcS
force-pushed
the
fix/eng-205-resolve-linked-resources-against-spec-dir
branch
from
September 28, 2026 07:35
886de4b to
32d0afc
Compare
Contributor
Author
|
@bananaplain that worked. Please check plainlang/plain-forge#25 too. |
NejcS
deleted the
fix/eng-205-resolve-linked-resources-against-spec-dir
branch
September 28, 2026 11:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make markdown-linked resources in a
.plainspec resolve against the directory containing that spec, so a render gives the same result no matter which directorycodeplainruns from.Issue reproduction verified from three directories — the module directory, its parent, and
/. All three now render identically.