Skip to content

feat: kill inline-login outro leak + shadcn MCP + helpbase add - #14

Merged
Codehagen merged 1 commit into
mainfrom
feat/inline-login-shadcn-mcp-add
Apr 19, 2026
Merged

Codehagen merged 1 commit into
mainfrom
feat/inline-login-shadcn-mcp-add

Conversation

@Codehagen

Copy link
Copy Markdown
Owner

Summary

Three DX fixes from a fresh pnpm dlx create-helpbase run, surfaced via /plan-devex-review:

  • Login outro leak. helpbase login, when spawned by create-helpbase during scaffold, was printing its own Next: helpbase deploy · rename · whoami panel + closing-bracket outro right in the middle of the scaffolder flow. Then create-helpbase printed its own What next panel a few seconds later with overlapping commands — two competing next-steps boxes within seconds. Gate login's outro + nextSteps behind HELPBASE_INLINE=1; set that env from both spawn call sites in create-helpbase (runHelpbaseLogin, runHelpbaseDeploy). The reservation note (the magical moment) still prints inline.
  • Shadcn MCP in scaffolded mcp.json. emit-mcp-json now emits a shadcn block alongside helpbase for all three client configs. Users get natural-language component install ("add a card component") from the same paste that wires up help-center citations. Compounds the "shadcn for docs" positioning.
  • helpbase add wrapper. New thin wrapper around npx shadcn@latest add. Forwards positional args + unknown flags, runs in cwd, exits with the subprocess status. Discoverable under the Author group in helpbase --help. First-time users find the shadcn-add pattern without leaving the helpbase CLI surface; power users keep calling npx shadcn directly.

Test plan

  • pnpm --filter helpbase typecheck — clean
  • pnpm --filter create-helpbase typecheck — clean
  • pnpm --filter helpbase test — 410 passing, no regressions
  • pnpm --filter create-helpbase test — 47 passing
  • pnpm --filter helpbase build && node packages/cli/dist/index.js --help — add listed in Author group
  • node packages/cli/dist/index.js add --help — local help shown with shadcn pointer
  • Cold-path manual: pnpm dlx create-helpbase@<published-tag> — verify only one "What next" panel post-merge + publish

🤖 Generated with Claude Code

Three DX fixes from a fresh `pnpm dlx create-helpbase` run, surfaced via
/plan-devex-review:

1. Inline login leaked its own "Next: helpbase deploy · rename · whoami"
   panel into the middle of the scaffolder, racing create-helpbase's own
   "What next" block. Gate login's outro+nextSteps behind HELPBASE_INLINE=1
   and set that env in both spawn() call sites in create-helpbase. The
   reservation note (the magical moment) still prints either way.

2. emit-mcp-json now emits a `shadcn` block alongside `helpbase` in all
   three client configs. Users get natural-language component install
   ("add a card") from the same paste that wires up help-center citations.
   Reinforces the "shadcn for docs" stance — every helpbase project IS a
   shadcn project, the agent that edits it can install more components.

3. New `helpbase add <component>` thin-wraps `npx shadcn@latest add`.
   Forwards args + unknown flags, runs in cwd, exits with the subprocess
   status. Listed under the Author group in --help. First-time users
   discover the shadcn-add pattern without leaving the helpbase CLI
   surface; power users keep using `npx shadcn` directly.

Tests: 410 passing helpbase + 47 passing create-helpbase, no regressions.
Typecheck clean on both packages.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Apr 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
helpbase Ready Ready Preview, Comment Apr 19, 2026 8:32am

Request Review

@coderabbitai

coderabbitai Bot commented Apr 19, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@Codehagen has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 54 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 18 minutes and 54 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 45690509-d3b9-4d7e-bfbc-f0ef276661a1

📥 Commits

Reviewing files that changed from the base of the PR and between 43dd1a4 and cceb284.

📒 Files selected for processing (6)
  • packages/cli/src/commands/add.ts
  • packages/cli/src/commands/login.ts
  • packages/cli/src/index.ts
  • packages/cli/src/lib/help.ts
  • packages/create-helpbase/src/emit-mcp-json.ts
  • packages/create-helpbase/src/index.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/inline-login-shadcn-mcp-add

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Codehagen
Codehagen merged commit 9a1b9c3 into main Apr 19, 2026
5 checks passed
@Codehagen
Codehagen deleted the feat/inline-login-shadcn-mcp-add branch April 19, 2026 08:37

This branch was successfully deployed

1 active deployment
Preview — cceb2848 Deployed Apr 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant