Skip to content

Preview: pre-rework design (old) — for A/B comparison - #1

Closed
Codehagen wants to merge 1 commit into
mainfrom
design/old
Closed

Codehagen wants to merge 1 commit into
mainfrom
design/old

Conversation

@Codehagen

Copy link
Copy Markdown
Owner

Pinned to commit 71060c8 (before the 2026-04-14 design rebuild).

Not for merge — this PR exists so Vercel produces a preview URL we can share
alongside the current main (new editorial-technical design) for qualitative
A/B feedback from target users.

Once feedback is collected and we pick a direction, close this PR.

This empty commit exists solely so Vercel treats design/old as
distinct from main and spins up a preview URL. Pinned state is
the commit one back (71060c8 — pre design rebuild).
@vercel

vercel Bot commented Apr 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
helpbase Ready Ready Preview, Comment Apr 15, 2026 6:51am

Request Review

@coderabbitai

coderabbitai Bot commented Apr 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f61e2f1d-e7a6-49c4-af82-68d49d04ca64

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch design/old

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Codehagen

Copy link
Copy Markdown
Owner Author

Closing — picked the old design. Rebuild preserved on design/new-abandoned branch in case we revisit. Main reverted cleanly back to 71060c8 state.

@Codehagen Codehagen closed this Apr 15, 2026
@Codehagen
Codehagen deleted the design/old branch April 15, 2026 07:37
Codehagen added a commit that referenced this pull request Apr 22, 2026
Second cold-verify round on a fresh repo surfaced three more blockers.
All three fixed in one release so Shadcn's audience hits clean DX on
first install.

Bug A (sync.ts): github.event.before on brand-new repos is 40 zeros.
git diff against that emits "bad object 000...", which my existing
rev-resolution regex (unknown revision|bad revision) did not match,
so sync crashed with a raw throw instead of the E_INVALID_REV path.
Extended regex to also match "bad object" and "ambiguous argument"
(the latter also covers HEAD~N past history). Under --yes, unresolved
rev is now treated the same as empty diff: exit 0 with a note. Users
interactive still get the targeted error.

Bug B (workflow YAML): `gh pr create` fails with "not permitted to
create or approve pull requests" on repos where the GitHub-Actions-
can-open-PRs permission isn't enabled (default is OFF). This hits
literally every first-time installer. The branch push succeeds —
just the PR-open call 403s.

The workflow now catches that specific failure mode, prints a
::warning:: pointing at (a) the branch URL for manual PR creation,
(b) the Settings URL to flip the permission once, and exits 0.
Any other gh pr create failure still hard-fails the Action.

Also bug fix: --base main was hardcoded. Swapped to
${GITHUB_REF_NAME} so the workflow handles master / trunk / whatever
the default branch is.

Bug C (README): a new "One-time setup" section documents the
Actions-permission enable in both Settings UI form and gh api CLI
form. Users who flip it once get auto-PRs; users who don't get the
branch + warning fallback.

Regression tests in cli.integration.test.ts for both the zero-SHA
and the deep-HEAD~N unresolvable-rev cases, covering both --yes
(exit 0) and interactive (exit 1 + E_INVALID_REV) shapes.

Cold-verify evidence before this commit (Codehagen/helpbase-oidc-
verify-v081-20260422-214257 repo):
  Run 1: first push — failed on 40-zero SHA (fixed by Bug A)
  Run 2: second push — LLM generated perfect citation-grounded
         proposal, branch pushed, PR-create blocked (fixed by Bug B)
  Run 3: third push with permission manually enabled — full green,
         PR #1 opened with the proposed docs update. Proves the
         backend + OIDC + quota + LLM chain works end-to-end.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
Preview — aabe9223 Deployed Apr 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant