London | 26-ITP | Mars Adesina | Sprint 2 | Javascript Fundamentals by marscancode · Pull Request #1559 · CodeYourFuture/Module-JavaScript-Fundamentals

marscancode · 2026-09-21T14:53:32Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1039

Changelist

Completed all 4 sections of the sprint-2 coursework.

netlify · 2026-09-21T15:16:18Z

❌ Deploy Preview for cyf-onboarding-module failed. Why did it fail? →

Name	Link
🔨 Latest commit	`cae3793`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab144f92a8cf800088a0dec

netlify · 2026-09-21T15:16:24Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`538ff7d`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab193e7b208690008360ade
😎 Deploy Preview	https://deploy-preview-1559--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

abdishakoor-dev

Good work on this sprint. Your prediction in 2-mandatory-errors/3.js is honest and clear. You say what you expected and what was different.

Four things to fix before I can mark it Complete:

1-key-exercises/4-random.js line 5: this line stops the file with an error. Remove it.
1-key-exercises/4-random.js line 14: the answer needs to say what num is. See my comment on that line.
2-mandatory-errors/1.js: the fix works, but the error and the reason are not written down.
1-key-exercises/3-paths.js line 18: ext only works for this one file name.

Also, "My code is consistently formatted" is on the checklist. The tool that does this is called Prettier. It sets spacing and indentation to one agreed style. Then a reviewer only sees the changes you meant to make. At the moment 2-mandatory-errors/0.js fails that check.

Prettier comes with the CYF extension pack from onboarding. If you are not sure you have it, open VS Code, go to Extensions, and search for CodeYourFuture Extension Pack: https://marketplace.visualstudio.com/items?itemName=CodeYourFuture.cyf-extension-pack

Open 0.js, right click in the editor, and choose Format Document. Pick Prettier if VS Code asks. Save and commit. To format every time you save, follow the format on save steps here: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Add the Needs Review label again once you have pushed.

abdishakoor-dev · 2026-09-21T15:38:05Z

 const maximum = 100;

 const num = Math.floor(Math.random() * (maximum - minimum + 1)) + minimum;
+num = Math.floor(Math.random(0.9) * (100 - 1 + 1)) + 1;


Run node 4-random.js inside the Sprint-2/1-key-exercises folder. What is the first line of the error?

num is declared with const on line 4. A const cannot get a new value. Please delete line 5.

abdishakoor-dev · 2026-09-21T15:38:05Z

+//console.log(num)
+//output: random whole number
+
+// So num is storing the value of a random number generated by the method Math.random this will be a number between zero and one that is then  multiplied by 100 (100(maximum) -1(minimum) +1)  and then whatever this number is, one is added on to that number and then finally the Math.floor method will round that number down to the nearest whole number add one and this final number is what is stored in the variable num.


Two things in this answer.

First, you say one is added before Math.floor, and again after it. The + minimum happens once. Look at the brackets on line 4. Which happens first, Math.floor or + minimum?

Second, finish with what num is. What is the smallest value it can be? What is the largest?

abdishakoor-dev · 2026-09-21T15:38:05Z

 // trying to create an age variable and then reassign the value by 1

-const age = 33;
+let age = 33;


The fix is right. The exercise also asks for the error and the reason.

The starter had const age = 33; on this line. Add a comment with the first line of the error node printed. Then say in your own words why it happened.

Tip: the error in 1-key-exercises/4-random.js right now is the same one.

abdishakoor-dev · 2026-09-21T15:38:05Z

-
-// https://www.google.com/search?q=slice+mdn
+const dir = filePath.slice(0, lastSlashIndex);
+const ext = base.slice(4);


This gives .txt for file.txt. What does it give if base is photo.jpeg?

The number 4 only fits a name with four letters. How can you find where the . is, like you found the last / on line 13?

slice(-4) still counts four characters from the end. What does it give for photo.jpeg?

The . is not always four characters from the end. On line 13 you used lastIndexOf to find the last /. Can you do the same for the .?

I have made the changes and pushed it now. I didn't think about the slice method not working for every extension type because they differ in length but after reviewing my code on line 13, I understand now why using the lastindex of method for the ext variable is correct here! Thanks so much Abdi!

That's the one. Your comment on line 19 explains it well.

marscancode · 2026-09-21T16:48:52Z

Thankyou for reviewing my work Abdi! I have fixed my code to be in line with the things you pointed out and i've pushed the changes so hopefully all should be correct now.

abdishakoor-dev

Thank you for the quick fixes. Your answer in 4-random.js is now clear. It gives the order and the range 1 to 100.

One thing left: ext in 1-key-exercises/3-paths.js. See my reply on line 18.

Add the Needs Review label again once you have pushed.

abdishakoor-dev

ext is fixed. It gives .txt for file.txt and .jpeg for photo.jpeg.

One small note, no need to change it now. Line 12 has an extra photo/ in the path. So the //44 comment on line 13 is out of date.

Marking this Complete. Well done.

marscancode added 30 commits September 11, 2026 11:57

Added comments covering form requirements

269946f

Added customer requirements comment

b2c7381

Added name validation to form

e289781

Added email validation to form

74a67c9

Added colour selector validation to form

e25b334

Added size selector valdation to form

ec30f47

Finished t-shirt form validation

8f87ed4

Refactored form using devtools and updated requirements

297191f

Updated form semantics

8497414

added description of code on line 3

85aded1

declared variable that stores first character of each string

c8979e7

added directory variable for file path

71e889b

added extension variable for file path

f0c63cb

explanation of what num represents

a08fe81

used a comment in javascript

014e42a

changed const to let for age variable

4d81b9f

explained using a comment and initialised cityOfBirth variable on line 3

95adf58

added prediction of why code on line 1 and 2 wont work

f920359

explained why my prediction was wrong

7ec6995

fixed typeError by changing cardNumberfrom a number to a string

ed25b1d

fixed syntax error by updating both variable names

ee9f94c

identified all function calls in file in a comment

a16ba75

identified the error and fixed the syntax error on line 5

e3fabaf

Identified variable reassignment statements

34357e2

identified all variable declarations in file

336102c

described what the expression on line 4 is doing

6d81f32

Identified all variable declarations in file

baf6433

Identified 1 function call in file

efa997d

explained what the expression on line 3 is doing

eca4da2

explained what the expression assigned to totalMinutes means.

7cf3da9

This comment has been minimized.

Sign in to view

marscancode added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 21, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 21, 2026

This comment has been minimized.

Sign in to view

fix: reset accidental file changes outside sprint 2

157f416

marscancode added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 21, 2026

abdishakoor-dev reviewed Sep 21, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 21, 2026

marscancode added 5 commits September 21, 2026 16:57

removed line 5

2886191

added clearer description of variable num

2de6944

updated file with error type and explanation

9a8d497

updated code on line 18

7c792ee

formatted text using prettier

ae092fd

marscancode added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 21, 2026

abdishakoor-dev reviewed Sep 21, 2026

View reviewed changes

abdishakoor-dev removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 21, 2026

marscancode added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 21, 2026

updated ext variable to use the lastindexof method and explained why

538ff7d

marscancode added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 21, 2026

abdishakoor-dev reviewed Sep 22, 2026

View reviewed changes

Uh oh!

Conversation

marscancode commented Sep 21, 2026

Learners, PR Template

Task code

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

netlify Bot commented Sep 21, 2026

❌ Deploy Preview for cyf-onboarding-module failed. Why did it fail? →

Uh oh!

netlify Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

marscancode Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

marscancode commented Sep 21, 2026

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Sep 21, 2026 •

edited

Loading