Repository navigation
Skip remote database engines when scanning materialized views - #804
Open
alexsubota wants to merge 2 commits into
Open
alexsubota wants to merge 2 commits into
alexsubota wants to merge 2 commits into
Conversation
An unreachable MySQL database engine makes an unfiltered system.tables scan fail for every model. Limit the associated-view lookup to the model database, and restrict relation listing to local databases so source() on a remote schema still connects only to that schema.
alexsubota
force-pushed
the
fix/skip-remote-engines-when-scanning-mvs
branch
from
November 16, 2026 08:32
13b7c9c to
f9a4fc5
Compare
koletzilla
requested changes
Nov 16, 2026
| select name | ||
| from system.tables | ||
| where engine = 'MaterializedView' | ||
| where database = '{{ relation_schema }}' |
Contributor
There was a problem hiding this comment.
This is too limiting, a user may create a MV from another database.
| where engine = 'MaterializedView' | ||
| and create_table_query like '%TO %' | ||
| {%- if ns.local_databases %} | ||
| and database in ({% for db_name in ns.local_databases %}'{{ db_name | replace("'", "''") }}'{% if not loop.last %}, {% endif %}{% endfor %}) |
Contributor
There was a problem hiding this comment.
Can we just add the filtering here somehow by calling system.databases and filtering by other values? feels like adding two sequentials queries should not be the way to go and maybe one is enough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
system.tablesscan for every model.source()on a remote schema still queries that schema directly.Test plan
source()on a MySQL or PostgreSQL database engine still reads that schema.Note
Low Risk
Targeted macro changes to relation-listing SQL; behavior improves resilience with mixed local/remote engines and does not alter explicit remote
source()access.Overview
Relation listing and materialized-view discovery no longer trigger connections to MySQL, PostgreSQL, or MaterializedMySQL database engines.
clickhouse__list_relations_without_cachingfirst loads local database names fromsystem.databases(engines excluded without connecting) and restricts thesystem.tablesmaterialized-view scan to those databases, so a single unreachable remote DB cannot break listing for every schema.The associated MV lookup in
clickhouse__search_associated_mvs_to_targetis scoped withdatabase = '<model schema>'instead of scanning all databases.source()on a remote engine schema is unchanged: the outer relation-list query still filters by that schema directly.Reviewed by Cursor Bugbot for commit f9a4fc5. Bugbot is set up for automated code reviews on this repo. Configure here.