Repository navigation
Skip remote database engines when scanning materialized views - #803
Closed
alexsubota wants to merge 2 commits into
Closed
alexsubota wants to merge 2 commits into
alexsubota wants to merge 2 commits into
Conversation
An unreachable MySQL database engine makes an unfiltered system.tables scan fail for every model. Limit the associated-view lookup to the model database, and restrict relation listing to local databases so source() on a remote schema still connects only to that schema. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
system.tablesscan for every model.source()on a remote schema still queries that schema directly.Test plan
source()on a MySQL or PostgreSQL database engine still reads that schema.Made with Cursor
Note
Low Risk
Narrower SQL filters for catalog/MV discovery; behavior change is limited to avoiding failed remote connections, with remote
source()still explicit.Reviewed by Cursor Bugbot for commit a73cea7. Bugbot is set up for automated code reviews on this repo. Configure here.