Repository navigation
fix(clearance): poll for sw keepalive alarm confirmation - #210
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make_sw_keepalive_checkerso transientFalsealarm reads retry before blocking the harnessswKeepalivealarm is absent (False); stops early onTrueNoneas the SW-unreachable diagnostic — not retried, not misreported as alarm-missing_DIAGNOSTIC_READ_TIMEOUT_SenvelopeRoot cause
Real smoke on v0.47.10 blocked at
sw_keepalive_confirmedwithsw_keepalive_alarm_present: False. The MV3 extension creates theswKeepalivealarm asynchronously inchrome.storage.onChanged; the previous single-shot CDP read raced against that creation and consistently saw the alarm absent.Test plan
test_false_is_retried_and_resolves_true— False retries, True terminates earlytest_false_repeatedly_returns_false_after_max_attempts— bounded loop, not infinitetest_none_not_retried_returns_none— SW-unreachable exits on first calltest_false_then_none_returns_none— mid-retry None is returned correctlyruff checkandflake8cleanCloses #209