Repository navigation
randomNames 1.7-0.0: input validation, tests, hex logo and a new Quarto site - #92
Open
dbetebenner wants to merge 6 commits into
Open
dbetebenner wants to merge 6 commits into
dbetebenner wants to merge 6 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ite deploys from Actions Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set.seed()gives the same names as 1.6-0.0.n,which.namesorname.orderis now an error (it printed a note or silently returnedNULL). Gender and ethnicity values that match nothing are still drawn at random, now with a warning.ethnicity = c(1, 7, 3)).@get) and dead code; fixes Rd that described awhich.names = "complete.data"that never existed and left out ethnicity 6 in the data docs.cliforcrayon, nopkgsearch; the startup banner is interactive only, has a two-second timeout and two off switches.ui/www, generated withdataimago::create_package_site().CITATION.cffhad the author's given and family names swapped; fixed.About the ethnicity default
The plan flagged the default ethnicity draw as never producing category 6. That turned out to be dead code: the
round(runif(1, 5))lines are unreachable becausemissing(ethnicity)is false afterethnicity <- NA. The live path draws uniformly from 1 to 6 (checked: 5000 draws gave 769-881 per category), as documented. So seeded output does not change and nothing needs sign-off; the dead lines are removed.Deployment (do this before merging)
Set Settings → Pages → Source to GitHub Actions first.
docs/and_pkgdown.ymlstay in this PR so the live site keeps working until then; a follow-up PR removes them.Test plan
R CMD check --as-cranlocally (no errors or warnings)devtools::test(): seeded golden values unchangedMade with Cursor