Skip to content

randomNames 1.7-0.0: input validation, tests, hex logo and a new Quarto site - #92

Open
dbetebenner wants to merge 6 commits into
CenterForAssessment:masterfrom
dbetebenner:refresh/site-and-tests
Open

dbetebenner wants to merge 6 commits into
CenterForAssessment:masterfrom
dbetebenner:refresh/site-and-tests

Conversation

@dbetebenner

@dbetebenner dbetebenner commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Adds a testthat 3e test suite (there was none). It pins seeded output: the same set.seed() gives the same names as 1.6-0.0.
  • An invalid n, which.names or name.order is now an error (it printed a note or silently returned NULL). Gender and ethnicity values that match nothing are still drawn at random, now with a warning.
  • Fixes valid numeric codes being thrown away when mixed with text or with an invalid code (ethnicity = c(1, 7, 3)).
  • Removes the plumber leftover (@get) and dead code; fixes Rd that described a which.names = "complete.data" that never existed and left out ethnicity 6 in the data docs.
  • roxygen2 documentation, cli for crayon, no pkgsearch; the startup banner is interactive only, has a two-second timeout and two off switches.
  • New hex logo and a Quarto site in ui/www, generated with dataimago::create_package_site().
  • CITATION.cff had the author's given and family names swapped; fixed.

About the ethnicity default

The plan flagged the default ethnicity draw as never producing category 6. That turned out to be dead code: the round(runif(1, 5)) lines are unreachable because missing(ethnicity) is false after ethnicity <- NA. The live path draws uniformly from 1 to 6 (checked: 5000 draws gave 769-881 per category), as documented. So seeded output does not change and nothing needs sign-off; the dead lines are removed.

Deployment (do this before merging)

Set Settings → Pages → Source to GitHub Actions first. docs/ and _pkgdown.yml stay in this PR so the live site keeps working until then; a follow-up PR removes them.

Test plan

  • R CMD check --as-cran locally (no errors or warnings)
  • devtools::test(): seeded golden values unchanged
  • R-CMD-check workflow on all five platforms

Made with Cursor

dbetebenner and others added 6 commits October 31, 2026 11:39
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ite deploys from Actions

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant