Repository navigation
Remove obsolete CarterModule - #388
Merged
Merged
Conversation
CarterModule was marked obsolete with a notice that it would be removed in the next version. Remove it, so MapCarter now simply calls AddRoutes on every ICarterModule. Module-wide settings such as a base path, authorization or before/after hooks are expressed with MapGroup and endpoint filters inside AddRoutes, as the Directors sample now shows. Co-Authored-By: Claude <noreply@anthropic.com>
jchannon
force-pushed
the
remove-carter-module
branch
from
November 11, 2026 14:47
f192613 to
867df3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #387.
CarterModulewas marked[Obsolete]with the message "CarterModule will be removed in the next version. Please migrate to ICarterModule." This removes it.CarterModulebase class is gone, along with its module-wide settings (basePath,RequireAuthorization,RequireHost,RequireCors,WithTags,WithCacheOutput,RequireRateLimiting,Before/After, etc.).MapCarternow just callsAddRouteson every registeredICarterModule.DirectorsModulesample is converted toICarterModule, usingMapGroup("/directors")and an endpoint filter in place of the base path andBefore/Afterhooks. This is the migration path for existingCarterModuleusers.AuthorizationTestsandAuthorizationTestModuleare deleted: they only coveredCarterModule.RequireAuthorization.CARTER2analyzer (derived modules with constructor dependencies) is unchanged, since it applies to any class inheritingICarterModulethrough a base class.🤖 Generated with Claude Code