Repository navigation
Cleanup the code - #61
Merged
Merged
Conversation
Co-authored-by: Langning Zhang <145515129+Boulea7@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Trims comments across the crate to short why-notes and deletes the ones that only restated the code. Repeated magic numbers get names, and a few duplicated bits are folded into helpers. README and examples are shortened. No behaviour change.
Why
Comments had grown into essays and a lot of literals were scattered around. This makes the files quicker to read and edit.
How it was verified
cargo testpassescargo clippy --all-targets -- -D warningsis cleancuda_parityon a GPU--releaseAlso:
cargo dochas no warnings andcargo check --examplesandcargo check --features cudabuild. The.cuedits are comment and dead-code removal plus two named constants, and a standalonenvcccompile ofkernels.cuhad no errors.Checklist
tensor/opsandautograd/opsstill mirror each other///docsNo new rules or kernels in this PR, so the first two are untouched. Tolerances and test cases are unchanged.
Notes
tensor/mod.rs,tensor/checked.rs,autograd/anomaly.rs,nn/mod.rs) along with the "Adding an op" list inautograd/mod.rs.fastnn_cuda_argmaxandfastnn_cuda_scaled_dot_product_attentioninkernels.culook broken and are not in the Rust FFI. Left alone here, will deal with them separately.