Repository navigation
[PD1-1117] Remove the duplicate Python license-check workflow - #34
Merged
Merged
Conversation
license-check-python.yml predates the fleet-managed pyproject-license-check.yml and duplicates it: same workflow name, same trigger, same job, but an older action pin and no CodeArtifact access. Both ran on every push. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/license-check-python.ymlpredates the fleet-wide license-check rollout and has been running alongside the workflow that replaced it. This removes it.Why it is redundant
It is a near-copy of the fleet-managed
.github/workflows/pyproject-license-check.yml, whichcvec-management-accountpushes into every repository GitHub detects as Python:license-check-python.yml(removed)pyproject-license-check.yml(kept)Python License CheckPython License Checkon: pushon: pushlicense-checkonubuntu-24.04license-checkonubuntu-24.04pyproject-license-check@977092b2(v0.1.0)pyproject-license-check@d56c86ec(v0.5.1)id-token: write+ AWS credentialsBoth fire on every push — the last three runs of each started at the same second — so every push has been paying for the license check twice.
Three things follow from that:
actions/create-github-app-token@v2.2.1, a Node 20 action, so it was still emitting theNode.js 20 is deprecated.warning. Deleting it clears that warning without needing a re-pin.workflow_runselects onname:, not filename, so a duplicate name is a hazard for any automation built on it.Verification
license-check-python.mainhas no branch protection, so no required status check named after this workflow can be orphaned. The kept workflow reports the samePython License Checkname regardless.actionlintandzizmorare clean on the branch.Part of the fleet-wide sweep for PD1-1117.
🤖 Generated with Claude Code