Skip to content

Proposal: EQ band controls in a room of their own under the graph - #61

Open
marcin-koziol wants to merge 1 commit into
BurningTreeC:mainfrom
marcin-koziol:eq-band-controls-room
Open

marcin-koziol wants to merge 1 commit into
BurningTreeC:mainfrom
marcin-koziol:eq-band-controls-room

Conversation

@marcin-koziol

Copy link
Copy Markdown

This is a proposal, not a fix of a bug. It changes how the EQ editor looks, so feel free to reject it or take only the idea. In our opinion this layout is a lot less annoying to work with, so we wanted to show it rather than just describe it.

The problem

In the built-in EQ the band controls panel lies over the foot of the graph. As soon as a band is cut deep (or a dynamic band's range is pulled down), its node and the part of the curve you are shaping disappear under the panel, exactly while you are editing that band. You end up deselecting, looking, selecting again.

We first tried flipping the panel to the top of the graph when the band goes low, but it felt worse: the panel jumps around, and you have to look for it.

The proposal

Keep a fixed strip for the band controls between the frequency scale and the bottom bar:

  • the graph is ~128 px lower, but no curve, node or range handle is ever covered;
  • the panel stays where you expect it (it still follows the band horizontally);
  • with nothing selected the strip shows a dim hint: "Click a band to edit it · double-click the curve to add one";
  • an editor too low to spare the room (graph would be under 160 px) keeps the current overlay behaviour;
  • an expanded dynamic band's second row is taller than the strip and still reaches up over the graph (rare, left as is).

Changes

  • eq/geometry.rs: Layout::panel, the strip, sized from the panel's first row (PANEL_ROW_H), with the low-editor fallback.
  • eq/panel.rs: the panel sits in the strip when there is one; the hint when nothing is selected.
  • eq/tests.rs: the_band_controls_have_their_own_room_under_the_graph (a −30 dB cut is not covered; the fallback in a low editor).

cargo test -p faderframe-view-devices (66 tests) and clippy pass.

🤖 Generated with Claude Code

The band controls lay over the foot of the graph, so a band cut deep
(or a dynamic band's range pulled down) went under them while being
edited. The editor now keeps a strip for them between the frequency
scale and the bottom bar; the graph is that much lower and no curve or
node is ever covered. With nothing selected the strip says how to edit
or add a band. An editor too low to spare the room (graph under 160 px)
keeps the old overlay; an expanded dynamic band's second row still
reaches up over the graph.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants