Repository navigation
Proposal: EQ band controls in a room of their own under the graph - #61
Open
marcin-koziol wants to merge 1 commit into
Open
marcin-koziol wants to merge 1 commit into
marcin-koziol wants to merge 1 commit into
Conversation
The band controls lay over the foot of the graph, so a band cut deep (or a dynamic band's range pulled down) went under them while being edited. The editor now keeps a strip for them between the frequency scale and the bottom bar; the graph is that much lower and no curve or node is ever covered. With nothing selected the strip says how to edit or add a band. An editor too low to spare the room (graph under 160 px) keeps the old overlay; an expanded dynamic band's second row still reaches up over the graph. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
In the built-in EQ the band controls panel lies over the foot of the graph. As soon as a band is cut deep (or a dynamic band's range is pulled down), its node and the part of the curve you are shaping disappear under the panel, exactly while you are editing that band. You end up deselecting, looking, selecting again.
We first tried flipping the panel to the top of the graph when the band goes low, but it felt worse: the panel jumps around, and you have to look for it.
The proposal
Keep a fixed strip for the band controls between the frequency scale and the bottom bar:
Changes
eq/geometry.rs:Layout::panel, the strip, sized from the panel's first row (PANEL_ROW_H), with the low-editor fallback.eq/panel.rs: the panel sits in the strip when there is one; the hint when nothing is selected.eq/tests.rs:the_band_controls_have_their_own_room_under_the_graph(a −30 dB cut is not covered; the fallback in a low editor).cargo test -p faderframe-view-devices(66 tests) and clippy pass.🤖 Generated with Claude Code